diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index d16d688fc..991e6503c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -25,7 +25,7 @@ jobs: - name: "Install PHP" uses: shivammathur/setup-php@v2 with: - php-version: "7.2" + php-version: "7.4" coverage: none tools: pecl extensions: ast, gd, imagick, json, mbstring @@ -46,7 +46,7 @@ jobs: matrix: os: - ubuntu-latest - - windows-latest +# - windows-latest php-version: - "7.2" - "7.3" diff --git a/tests/Output/QRImageTest.php b/tests/Output/QRImageTest.php index 34ecf4f91..c4466a658 100644 --- a/tests/Output/QRImageTest.php +++ b/tests/Output/QRImageTest.php @@ -13,6 +13,7 @@ namespace chillerlan\QRCodeTest\Output; use chillerlan\QRCode\{QRCode, Output\QRImage}; +use const PHP_MAJOR_VERSION; class QRImageTest extends QROutputTestAbstract{ @@ -63,7 +64,14 @@ class QRImageTest extends QROutputTestAbstract{ $this->setOutputInterface(); - $this::assertIsResource($this->outputInterface->dump()); + $data = $this->outputInterface->dump(); + + if(PHP_MAJOR_VERSION >= 8){ + $this::assertInstanceOf('\\GdImage', $data); + } + else{ + $this::assertIsResource($data); + } } }