From 90d33b67434d05e81d2a662763ead447565f019e Mon Sep 17 00:00:00 2001 From: codemasher Date: Sun, 21 Jan 2018 14:13:39 +0100 Subject: [PATCH] :octocat: no assignments in method signatures --- src/Helpers/Polynomial.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Helpers/Polynomial.php b/src/Helpers/Polynomial.php index ac86f3421..ff1468759 100644 --- a/src/Helpers/Polynomial.php +++ b/src/Helpers/Polynomial.php @@ -68,8 +68,8 @@ class Polynomial{ * @param array $num * @param int $shift */ - public function __construct(array $num = [1], int $shift = 0){ - $this->setNum($num, $shift); + public function __construct(array $num = null, int $shift = null){ + $this->setNum($num ?? [1], $shift); } /** @@ -85,7 +85,7 @@ class Polynomial{ * * @return \chillerlan\QRCode\Helpers\Polynomial */ - public function setNum(array $num, int $shift = 0):Polynomial { + public function setNum(array $num, int $shift = null):Polynomial { $offset = 0; $numCount = count($num); @@ -93,7 +93,7 @@ class Polynomial{ $offset++; } - $this->num = array_fill(0, $numCount - $offset + $shift, 0); + $this->num = array_fill(0, $numCount - $offset + ($shift ?? 0), 0); for($i = 0; $i < $numCount - $offset; $i++){ $this->num[$i] = $num[$i + $offset];