From 97f16b017dc8ab8aa67dfb18bb9a5ba5bbec5f82 Mon Sep 17 00:00:00 2001 From: smiley Date: Mon, 30 Jan 2023 18:14:02 +0100 Subject: [PATCH] :octocat: skip failing test under PHP-WIN < 8.1 --- tests/QRCodeReaderImagickTest.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/QRCodeReaderImagickTest.php b/tests/QRCodeReaderImagickTest.php index ffa791804..0c623b289 100644 --- a/tests/QRCodeReaderImagickTest.php +++ b/tests/QRCodeReaderImagickTest.php @@ -13,7 +13,7 @@ namespace chillerlan\QRCodeTest; use chillerlan\QRCode\Decoder\IMagickLuminanceSource; use chillerlan\QRCode\QRCode; use function extension_loaded; -use const PHP_OS_FAMILY; +use const PHP_OS_FAMILY, PHP_VERSION_ID; /** * Tests the Imagick based reader @@ -44,8 +44,6 @@ final class QRCodeReaderImagickTest extends QRCodeReaderTestAbstract{ } /** - * This test fails on Windows and PHP < 8.1 for whatever reason - * * @dataProvider vectorQRCodeProvider */ public function testReadVectorFormats(string $img, string $expected):void{ @@ -54,6 +52,10 @@ final class QRCodeReaderImagickTest extends QRCodeReaderTestAbstract{ $this::markTestSkipped('avoid imagick conversion errors (ha ha)'); } + if(PHP_OS_FAMILY === 'Windows' && PHP_VERSION_ID < 80100){ + $this::markTestSkipped('This test fails on Windows and PHP < 8.1 for whatever reason'); + } + $this::assertSame($expected, (string)(new QRCode) ->readFromSource(IMagickLuminanceSource::fromFile(__DIR__.'/samples/'.$img, $this->options))); }