geckon01/php-qrcode
1
0
Fork 0
mirror of https://github.com/chillerlan/php-qrcode.git synced 2026-08-24 13:17:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

:octocat: Version::$versionNumber: remove property getter in favor of asymmetric visibility

Browse Source
This commit is contained in:
smiley
2026-03-18 02:14:28 +01:00
parent 6b59d01c9e
commit a8076a113b
17 changed files with 33 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Data/DataInterfaceTestAbstract.php
+5 -5
View File
@@ -178,7 +178,7 @@ abstract class DataInterfaceTestAbstract extends TestCase{
#[DataProvider('maxLengthProvider')]
public function maxLength(Version $version, EccLevel $eccLevel, string $str, string $str1, int $len):void{
$options = new QROptions;
$options->version = $version->getVersionNumber();
$options->version = $version->versionNumber;
$options->eccLevel = $eccLevel->level;
$this->dataMode = static::getDataModeInterface($str);
@@ -207,13 +207,13 @@ abstract class DataInterfaceTestAbstract extends TestCase{
$this::assertLessThanOrEqual($eccLevel->getMaxBitsForVersion($version), $this->QRData->estimateTotalBitLength());
$minimumVersionNumber = $this->QRData->getMinimumVersion()->getVersionNumber();
$minimumVersionNumber = $this->QRData->getMinimumVersion()->versionNumber;
try{
$this::assertSame($version->getVersionNumber(), $minimumVersionNumber);
$this::assertSame($version->versionNumber, $minimumVersionNumber);
}
catch(ExpectationFailedException){
$this::assertSame(($version->getVersionNumber() + 1), $minimumVersionNumber, 'safety margin');
$this::assertSame(($version->versionNumber + 1), $minimumVersionNumber, 'safety margin');
}
// verify the encoded data
@@ -231,7 +231,7 @@ abstract class DataInterfaceTestAbstract extends TestCase{
$this->expectExceptionMessage('code length overflow');
$options = new QROptions;
$options->version = $version->getVersionNumber();
$options->version = $version->versionNumber;
$options->eccLevel = $eccLevel->level;