From b57d1703f6b1becb418d00a21ee327f028d9dd94 Mon Sep 17 00:00:00 2001 From: smiley Date: Fri, 8 Mar 2024 20:57:55 +0100 Subject: [PATCH] :octocat: --- .github/PULL_REQUEST_TEMPLATE.md | 8 +++++--- .github/workflows/ci.yml | 27 ++++++++++++++++++--------- 2 files changed, 23 insertions(+), 12 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7afaed339..5b4548551 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,11 +1,11 @@ - - ## Proposed changes + + ## Types of changes @@ -15,6 +15,8 @@ What types of changes does your code introduce? - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) +- [ ] Documentation fix or enhancement (no code was touched) +- [ ] Other (CI, dependencies, etc., please describe) ## Checklist: @@ -23,7 +25,7 @@ What types of changes does your code introduce? - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [ ] Any dependent changes have been merged and published in downstream modules -- [ ] Lint and unit tests pass locally with my changes +- [ ] Static analysis and unit tests pass locally with my changes ## Further comments diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 95c927cfe..75eb08712 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,5 +1,5 @@ -# https://help.github.com/en/categories/automating-your-workflow-with-github-actions -# https://github.com/sebastianbergmann/phpunit/blob/master/.github/workflows/ci.yml +# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions +# https://github.com/sebastianbergmann/phpunit/blob/main/.github/workflows/ci.yaml on: push: @@ -11,6 +11,10 @@ on: name: "Continuous Integration" +env: + PHP_EXTENSIONS: ast, fileinfo, gd, imagick, json, mbstring + PHP_INI_VALUES: memory_limit=-1, error_reporting=-1, display_errors=On + jobs: static-code-analysis: @@ -36,11 +40,12 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php-version }} + extensions: ${{ env.PHP_EXTENSIONS }} + ini-values: ${{ env.PHP_INI_VALUES }} coverage: none tools: pecl - extensions: ast, fileinfo, gd, imagick, json, mbstring - - name: "Update dependencies with composer" + - name: "Install dependencies with composer" uses: ramsey/composer-install@v3 - name: "Run phan" @@ -70,14 +75,15 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php-version }} + extensions: ${{ env.PHP_EXTENSIONS }} + ini-values: ${{ env.PHP_INI_VALUES }} coverage: pcov tools: pecl - extensions: fileinfo, gd, imagick, json, mbstring - name: "Install dependencies with composer" uses: ramsey/composer-install@v3 - - name: "Run tests with phpunit" + - name: "Run tests with PHPUnit" run: php vendor/bin/phpunit --colors=always --configuration=phpunit.xml.dist - name: "Send code coverage report to Codecov.io" @@ -105,10 +111,11 @@ jobs: - name: "Install PHP" uses: shivammathur/setup-php@v2 with: - php-version: "8.2" + php-version: "8.3" + extensions: ${{ env.PHP_EXTENSIONS }} + ini-values: ${{ env.PHP_INI_VALUES }} coverage: none tools: phpDocumentor - extensions: fileinfo, gd, imagick, json, mbstring - name: "Build API docs" run: phpdoc --config=phpdoc.xml.dist @@ -133,7 +140,9 @@ jobs: - name: "Install PHP" uses: shivammathur/setup-php@v2 with: - php-version: "8.2" + php-version: "8.3" + extensions: ${{ env.PHP_EXTENSIONS }} + ini-values: ${{ env.PHP_INI_VALUES }} coverage: none - name: "Install Sphinx"