From de3dd9a48044cfe56f2e6fe45315bd97f9d7653d Mon Sep 17 00:00:00 2001 From: smiley Date: Mon, 25 Jul 2022 11:04:58 +0200 Subject: [PATCH] :octocat: QRCode::isByte(): string "0" fails with empty() --- src/QRCode.php | 2 +- tests/QRCodeTest.php | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/QRCode.php b/src/QRCode.php index 294a20d83..908030feb 100755 --- a/src/QRCode.php +++ b/src/QRCode.php @@ -307,7 +307,7 @@ class QRCode{ * a dummy */ public function isByte(string $data):bool{ - return !empty($data); + return $data !== ''; } } diff --git a/tests/QRCodeTest.php b/tests/QRCodeTest.php index 523d7eb8c..56936a745 100755 --- a/tests/QRCodeTest.php +++ b/tests/QRCodeTest.php @@ -74,6 +74,7 @@ class QRCodeTest extends TestCase{ public function testIsByte():void{ $this::assertTrue($this->qrcode->isByte("\x01\x02\x03")); $this::assertTrue($this->qrcode->isByte(' ')); // not empty! + $this::assertTrue($this->qrcode->isByte('0')); $this::assertFalse($this->qrcode->isByte('')); }