[tests] Start improving test suite.

- Make use of more typehints for function parameters
- Make use of typehints for function return values
- Use @var where needed to give proper hints to IDEs and avoid warnings
- Replace MockObject::setMethods() with addMethods() and onlyMethods()
- Rewording of some phpdocs
This commit is contained in:
Daniele Alessandri
2020-08-28 18:59:10 +02:00
parent c2ede30394
commit 36c9bb047e
236 changed files with 2887 additions and 2454 deletions
@@ -12,6 +12,7 @@
namespace Predis\Configuration\Option;
use PredisTestCase;
use Predis\Configuration\OptionsInterface;
/**
*
@@ -21,9 +22,11 @@ class ExceptionsTest extends PredisTestCase
/**
* @group disconnected
*/
public function testDefaultOptionValue()
public function testDefaultOptionValue(): void
{
$option = new Exceptions();
/** @var OptionsInterface */
$options = $this->getMockBuilder('Predis\Configuration\OptionsInterface')->getMock();
$this->assertTrue($option->getDefault($options));
@@ -32,9 +35,11 @@ class ExceptionsTest extends PredisTestCase
/**
* @group disconnected
*/
public function testAcceptsDifferentValuesAndFiltersThemAsBooleans()
public function testAcceptsDifferentValuesAndFiltersThemAsBooleans(): void
{
$option = new Exceptions();
/** @var OptionsInterface */
$options = $this->getMockBuilder('Predis\Configuration\OptionsInterface')->getMock();
$this->assertFalse($option->filter($options, null));
@@ -55,9 +60,11 @@ class ExceptionsTest extends PredisTestCase
/**
* @group disconnected
*/
public function testReturnsFalesOnValuesNotParsableAsBooleans()
public function testReturnsFalesOnValuesNotParsableAsBooleans(): void
{
$option = new Exceptions();
/** @var OptionsInterface */
$options = $this->getMockBuilder('Predis\Configuration\OptionsInterface')->getMock();
$this->assertFalse($option->filter($options, new \stdClass()));