[tests] Start improving test suite.

- Make use of more typehints for function parameters
- Make use of typehints for function return values
- Use @var where needed to give proper hints to IDEs and avoid warnings
- Replace MockObject::setMethods() with addMethods() and onlyMethods()
- Rewording of some phpdocs
This commit is contained in:
Daniele Alessandri
2020-08-28 18:59:10 +02:00
parent c2ede30394
commit 36c9bb047e
236 changed files with 2887 additions and 2454 deletions
@@ -12,6 +12,8 @@
namespace Predis\Protocol\Text;
use PredisTestCase;
use PHPUnit\Framework\MockObject\MockObject;
use Predis\Command\CommandInterface;
/**
*
@@ -21,11 +23,12 @@ class ProtocolProcessorTest extends PredisTestCase
/**
* @group disconnected
*/
public function testConnectionWrite()
public function testConnectionWrite(): void
{
$serialized = "*1\r\n$4\r\nPING\r\n";
$protocol = new ProtocolProcessor();
/** @var CommandInterface|MockObject */
$command = $this->getMockBuilder('Predis\Command\CommandInterface')->getMock();
$command
->expects($this->once())
@@ -48,7 +51,7 @@ class ProtocolProcessorTest extends PredisTestCase
/**
* @group disconnected
*/
public function testConnectionRead()
public function testConnectionRead(): void
{
$protocol = new ProtocolProcessor();
@@ -84,7 +87,7 @@ class ProtocolProcessorTest extends PredisTestCase
/**
* @group disconnected
*/
public function testIterableMultibulkSupport()
public function testIterableMultibulkSupport(): void
{
$protocol = new ProtocolProcessor();
$protocol->useIterableMultibulk(true);
@@ -101,7 +104,7 @@ class ProtocolProcessorTest extends PredisTestCase
/**
* @group disconnected
*/
public function testUnknownResponsePrefix()
public function testUnknownResponsePrefix(): void
{
$this->expectException('Predis\Protocol\ProtocolException');
$this->expectExceptionMessage("Unknown response prefix: '!' [tcp://127.0.0.1:6379]");