geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-08-27 18:51:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests] Start improving test suite.

Browse Source 
- Make use of more typehints for function parameters
- Make use of typehints for function return values
- Use @var where needed to give proper hints to IDEs and avoid warnings
- Replace MockObject::setMethods() with addMethods() and onlyMethods()
- Rewording of some phpdocs
This commit is contained in:
Daniele Alessandri
2020-08-28 18:59:10 +02:00
parent c2ede30394
commit 36c9bb047e
236 changed files with 2887 additions and 2454 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Predis/Protocol/Text/RequestSerializerTest.php
+8 -3
View File
@@ -12,6 +12,8 @@
namespace Predis\Protocol\Text;
use PredisTestCase;
use PHPUnit\Framework\MockObject\MockObject;
use Predis\Command\CommandInterface;
/**
*
@@ -21,10 +23,11 @@ class RequestSerializerTest extends PredisTestCase
/**
* @group disconnected
*/
public function testSerializerIdWithNoArguments()
public function testSerializerIdWithNoArguments(): void
{
$serializer = new RequestSerializer();
/** @var CommandInterface|MockObject */
$command = $this->getMockBuilder('Predis\Command\CommandInterface')->getMock();
$command
->expects($this->once())
@@ -43,10 +46,11 @@ class RequestSerializerTest extends PredisTestCase
/**
* @group disconnected
*/
public function testSerializerIdWithArguments()
public function testSerializerIdWithArguments(): void
{
$serializer = new RequestSerializer();
/** @var CommandInterface|MockObject */
$command = $this->getMockBuilder('Predis\Command\CommandInterface')->getMock();
$command
->expects($this->once())
@@ -65,10 +69,11 @@ class RequestSerializerTest extends PredisTestCase
/**
* @group disconnected
*/
public function testSerializerDoesNotBreakOnArgumentsWithHoles()
public function testSerializerDoesNotBreakOnArgumentsWithHoles(): void
{
$serializer = new RequestSerializer();
/** @var CommandInterface|MockObject */
$command = $this->getMockBuilder('Predis\Command\CommandInterface')->getMock();
$command
->expects($this->once())