geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-10-13 23:37:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests] Rewrite the whole test suite to allow more granular testing.

Browse Source 
Fix also a few bugs found while rewriting the test suite.

In order to be able to run integration tests, the test suite requires
a version of Redis >= 2.4.0.

The units have been splitted into several different groups using
PHPUnit @group annotation to allow developers to enable, disable
and combine certain types of tests. The available groups are:

  - disconnected: can run without a Redis server online
  - connected: active connection to a Redis server is required
  - commands: test dedicated to a specific Redis command
  - slow: performs operations that can slow down execution;

A list of the available groups can be obtained by running

  phpunit --list-groups

Groups of tests can be disabled or enabled via the XML configuration
file or the standard command-line test runner. Please note that due
to a bug in PHPUnit, older versions ignore the --group option when
the group is excluded in the XML configuration file. Please refer to
http://github.com/sebastianbergmann/phpunit/issues/320 for details

Integration tests in the @connected group check if the command being
tested is defined in the selected server profile (see the value of
the TEST_SERVER_VERSION constant in phpunit.xml). If the command is
not defined in the target server profile, the integration test is
automatically marked as skipped.

We also provide an helper script in the bin directory that can be
used to automatically generate a file with the scheleton of a test
case for a Redis command by specifying the name of the class in the
Predis\Commands namespace. For example, to generate a test case for
SET (represented by the Predis\Commands\StringSet class):

  ./bin/generate-command-test.php --class=StringSet

The realm of a command is automatically inferred from the name of the
class, but it can be set using the --realm option.
This commit is contained in:
Daniele Alessandri
2011-12-03 09:57:09 +01:00
parent dd20e8557f
commit 371ac91777
234 changed files with 24387 additions and 3911 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Predis/Commands/ScriptedCommand.php
+13 -7
View File
@@ -27,12 +27,16 @@ abstract class ScriptedCommand extends ServerEval
*/
public abstract function getScript();
/*
/**
* Gets the number of arguments that should be considered as keys.
*
* @todo Should we make a scripted command act by default as a variadic
* command where the first argument is the key (KEYS[1]) and the
* rest is the list of values (ARGV)?
*
* @return int
*/
protected function keysCount()
public function getKeysCount()
{
// The default behaviour for the base class is to use all the arguments
// passed to a scripted command to populate the KEYS table in Lua.
@@ -40,18 +44,20 @@ abstract class ScriptedCommand extends ServerEval
}
/**
* {@inheritdoc}
* Returns the elements from the arguments that are identified as keys.
*
* @return array
*/
protected function filterArguments(Array $arguments)
public function getKeys()
{
return array_merge(array($this->getScript(), $this->keysCount()), $arguments);
return array_slice($this->getArguments(), 2, $this->getKeysCount());
}
/**
* {@inheritdoc}
*/
protected function getKeys()
protected function filterArguments(Array $arguments)
{
return array_slice($this->getArguments(), 2, $this->keysCount());
return array_merge(array($this->getScript(), $this->getKeysCount()), $arguments);
}
}