Use Predis\Response\Status to identify all kinds of status responses.

Status response objects are needed mostly to make it possible from the
client perspective to differentiate a status response with the payload
"OK" from a normale bulk reply containing "OK".

The biggest change is for commands returning +OK responses: these were
previously translated to TRUE (bool value), but they are now returned
as instances of Predis\Response\Status. Just to illustrate an example
of the possibilities with this change we will use SET since it is the
most widely used command returning +OK:

  $response = $client->set('foo', 'bar');

  echo $response;         // 'OK'
  $response == 'OK';      // TRUE
  isset($response->ok);   // TRUE
  $response == true;      // TRUE
  $response === true;     // FALSE
  $response instanceof Predis\Response\ObjectInterface;     // TRUE
  $response instanceof Predis\Response\Status;              // TRUE

For those checking responses returned by commands such as SET or PONG,
the breaking change basically lies in the usage of strict comparison:
doing $response === true will now evaluate to FALSE instead of TRUE.

By default Predis caches common status responses such as OK or QUEUED
to lower the memory usage when using pipelines or transactions.
This commit is contained in:
Daniele Alessandri
2013-12-07 12:01:27 +01:00
parent ac8d0c1f42
commit 373d30b070
62 changed files with 325 additions and 350 deletions
@@ -52,7 +52,7 @@ class StringPreciseSetExpireTest extends PredisCommandTestCase
*/
public function testParseResponse()
{
$this->assertTrue($this->getCommand()->parseResponse(true));
$this->assertSame('OK', $this->getCommand()->parseResponse('OK'));
}
/**
@@ -62,7 +62,7 @@ class StringPreciseSetExpireTest extends PredisCommandTestCase
{
$redis = $this->getClient();
$this->assertTrue($redis->psetex('foo', 10000, 'bar'));
$this->assertEquals('OK', $redis->psetex('foo', 10000, 'bar'));
$this->assertTrue($redis->exists('foo'));
$this->assertEquals(10, $redis->ttl('foo'));
}