geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-09-13 20:07:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tests] No need to reassign $exception.

Browse Source
This commit is contained in:
Daniele Alessandri
2013-12-22 14:05:27 +01:00
parent a092f6d4da
commit 728d9dceb5
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Predis/Pipeline/PipelineTest.php
+12 -6
View File
@@ -332,6 +332,8 @@ class PipelineTest extends PredisTestCase
*/ */
public function testExecuteWithCallableArgumentHandlesExceptions() public function testExecuteWithCallableArgumentHandlesExceptions()
{ {
$exception = null;
$connection = $this->getMock('Predis\Connection\SingleConnectionInterface'); $connection = $this->getMock('Predis\Connection\SingleConnectionInterface');
$connection->expects($this->never())->method('writeRequest'); $connection->expects($this->never())->method('writeRequest');
$connection->expects($this->never())->method('readResponse'); $connection->expects($this->never())->method('readResponse');
@@ -347,8 +349,8 @@ class PipelineTest extends PredisTestCase
throw new ClientException('TEST'); throw new ClientException('TEST');
$pipe->echo('two'); $pipe->echo('two');
}); });
} catch (Exception $ex) { } catch (Exception $exception) {
$exception = $ex; // NOOP
} }
$this->assertInstanceOf('Predis\ClientException', $exception); $this->assertInstanceOf('Predis\ClientException', $exception);
@@ -415,6 +417,8 @@ class PipelineTest extends PredisTestCase
*/ */
public function testIntegrationWithClientExceptionInCallableBlock() public function testIntegrationWithClientExceptionInCallableBlock()
{ {
$exception = null;
$client = $this->getClient(); $client = $this->getClient();
try { try {
@@ -422,8 +426,8 @@ class PipelineTest extends PredisTestCase
$pipe->set('foo', 'bar'); $pipe->set('foo', 'bar');
throw new ClientException('TEST'); throw new ClientException('TEST');
}); });
} catch (Exception $ex) { } catch (Exception $exception) {
$exception = $ex; // NOOP
} }
$this->assertInstanceOf('Predis\ClientException', $exception); $this->assertInstanceOf('Predis\ClientException', $exception);
@@ -436,6 +440,8 @@ class PipelineTest extends PredisTestCase
*/ */
public function testIntegrationWithServerExceptionInCallableBlock() public function testIntegrationWithServerExceptionInCallableBlock()
{ {
$exception = null;
$client = $this->getClient(); $client = $this->getClient();
try { try {
@@ -446,8 +452,8 @@ class PipelineTest extends PredisTestCase
$pipe->lpush('foo', 'bar'); $pipe->lpush('foo', 'bar');
$pipe->set('hoge', 'piyo'); $pipe->set('hoge', 'piyo');
}); });
} catch (Exception $ex) { } catch (Exception $exception) {
$exception = $ex; // NOOP
} }
$this->assertInstanceOf('Predis\Response\ServerException', $exception); $this->assertInstanceOf('Predis\Response\ServerException', $exception);