geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-10-09 21:38:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use 0 to indicate no arguments for KEYS[] in Lua scripted commands.

Browse Source 
We previously used FALSE for that but in the end it does not make much
sense. Luckily for us this does not represent a breaking change since
existing code will keep to work, so we can safely push this change into
the next patch release.
This commit is contained in:
Daniele Alessandri
2013-02-16 17:32:56 +01:00
parent fbcfdc343e
commit 729e40d6c0
3 changed files with 48 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Predis/Command/ScriptedCommandTest.php
+38
View File
@@ -60,6 +60,25 @@ class ScriptedCommandTest extends StandardTestCase
$this->assertSame(array_merge(array(self::LUA_SCRIPT_SHA1, 2), $arguments), $command->getArguments());
}
/**
* @group disconnected
*/
public function testGetArgumentsWithZeroKeysCount()
{
$arguments = array('value1', 'value2', 'value3');
$command = $this->getMock('Predis\Command\ScriptedCommand', array('getScript', 'getKeysCount'));
$command->expects($this->once())
->method('getScript')
->will($this->returnValue(self::LUA_SCRIPT));
$command->expects($this->once())
->method('getKeysCount')
->will($this->returnValue(0));
$command->setArguments($arguments);
$this->assertSame(array_merge(array(self::LUA_SCRIPT_SHA1, 0), $arguments), $command->getArguments());
}
/**
* @group disconnected
*/
@@ -79,6 +98,25 @@ class ScriptedCommandTest extends StandardTestCase
$this->assertSame(array('key1', 'key2'), $command->getKeys());
}
/**
* @group disconnected
*/
public function testGetKeysWithZeroKeysCount()
{
$arguments = array('value1', 'value2', 'value3');
$command = $this->getMock('Predis\Command\ScriptedCommand', array('getScript', 'getKeysCount'));
$command->expects($this->once())
->method('getScript')
->will($this->returnValue(self::LUA_SCRIPT));
$command->expects($this->exactly(2))
->method('getKeysCount')
->will($this->returnValue(0));
$command->setArguments($arguments);
$this->assertSame(array(), $command->getKeys());
}
/**
* @group disconnected
*/