From 83bab78bd151c3cdaaab3e64aad34c864d95e021 Mon Sep 17 00:00:00 2001 From: Daniele Alessandri Date: Fri, 8 Apr 2011 16:55:08 +0200 Subject: [PATCH] Rename the newConnection() method to create() in Predis\ConnectionFactory. --- lib/Predis/Client.php | 2 +- lib/Predis/ConnectionFactory.php | 6 +++--- lib/Predis/IConnectionFactory.php | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Predis/Client.php b/lib/Predis/Client.php index 8b5ca9bd..68401281 100644 --- a/lib/Predis/Client.php +++ b/lib/Predis/Client.php @@ -60,7 +60,7 @@ class Client { } private function createConnection($parameters) { - $connection = $this->_connectionFactory->newConnection($parameters); + $connection = $this->_connectionFactory->create($parameters); $this->pushInitCommands($connection); return $connection; } diff --git a/lib/Predis/ConnectionFactory.php b/lib/Predis/ConnectionFactory.php index eb9b2e44..9e9de153 100644 --- a/lib/Predis/ConnectionFactory.php +++ b/lib/Predis/ConnectionFactory.php @@ -40,7 +40,7 @@ class ConnectionFactory implements IConnectionFactory { self::$_globalSchemes[$scheme] = $connectionClass; } - public function newConnection($parameters) { + public function create($parameters) { if (!$parameters instanceof IConnectionParameters) { $parameters = new ConnectionParameters($parameters); } @@ -59,13 +59,13 @@ class ConnectionFactory implements IConnectionFactory { return new $connection($parameters); } - public function newConnectionByScheme($scheme, $parameters = array()) { + public function createByScheme($scheme, $parameters = array()) { if ($parameters instanceof IConnectionParameters) { $parameters = $parameters->toArray(); } if (is_array($parameters)) { $parameters['scheme'] = $scheme; - return $this->newConnection($parameters); + return $this->create($parameters); } throw new \InvalidArgumentException("Invalid type for connection parameters"); } diff --git a/lib/Predis/IConnectionFactory.php b/lib/Predis/IConnectionFactory.php index 7281f289..6a0bc154 100644 --- a/lib/Predis/IConnectionFactory.php +++ b/lib/Predis/IConnectionFactory.php @@ -3,5 +3,5 @@ namespace Predis; interface IConnectionFactory { - public function newConnection($parameters); + public function create($parameters); }