geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-10-10 13:57:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

use short array syntax

Browse Source
This commit is contained in:
Till Krüss
2023-01-17 13:48:22 -08:00
committed by Till Krüss
parent 31b65f614b
commit cc40219268
299 changed files with 3373 additions and 3373 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Predis/Replication/ReplicationStrategyTest.php
+28 -28
View File
@@ -83,13 +83,13 @@ class ReplicationStrategyTest extends PredisTestCase
$commands = $this->getCommandFactory();
$strategy = new ReplicationStrategy();
$cmdReturnSort = $commands->create('SORT', array('key:list'));
$cmdReturnSort = $commands->create('SORT', ['key:list']);
$this->assertFalse(
$strategy->isReadOperation($cmdReturnSort),
'SORT is expected to be a write operation.'
);
$cmdStoreSort = $commands->create('SORT', array('key:list', array('store' => 'key:stored')));
$cmdStoreSort = $commands->create('SORT', ['key:list', ['store' => 'key:stored']]);
$this->assertFalse(
$strategy->isReadOperation($cmdStoreSort),
'SORT with STORE is expected to be a write operation.'
@@ -104,37 +104,37 @@ class ReplicationStrategyTest extends PredisTestCase
$commands = $this->getCommandFactory();
$strategy = new ReplicationStrategy();
$command = $commands->create('BITFIELD', array('key'));
$command = $commands->create('BITFIELD', ['key']);
$this->assertTrue(
$strategy->isReadOperation($command),
'BITFIELD with no modifiers is expected to be a read operation.'
);
$command = $commands->create('BITFIELD', array('key', 'GET', 'u4', '0'));
$command = $commands->create('BITFIELD', ['key', 'GET', 'u4', '0']);
$this->assertTrue(
$strategy->isReadOperation($command),
'BITFIELD with GET only is expected to be a read operation.'
);
$command = $commands->create('BITFIELD', array('key', 'SET', 'u4', '0', 1));
$command = $commands->create('BITFIELD', ['key', 'SET', 'u4', '0', 1]);
$this->assertFalse(
$strategy->isReadOperation($command),
'BITFIELD with SET is expected to be a write operation.'
);
$command = $commands->create('BITFIELD', array('key', 'INCRBY', 'u4', '0', 1));
$command = $commands->create('BITFIELD', ['key', 'INCRBY', 'u4', '0', 1]);
$this->assertFalse(
$strategy->isReadOperation($command),
'BITFIELD with INCRBY is expected to be a write operation.'
);
$command = $commands->create('BITFIELD', array('key', 'GET', 'u4', '0', 'INCRBY', 'u4', '0', 1));
$command = $commands->create('BITFIELD', ['key', 'GET', 'u4', '0', 'INCRBY', 'u4', '0', 1]);
$this->assertFalse(
$strategy->isReadOperation($command),
'BITFIELD with GET and INCRBY is expected to be a write operation.'
);
$command = $commands->create('BITFIELD', array('key', 'GET', 'u4', '0', 'SET', 'u4', '0', 1));
$command = $commands->create('BITFIELD', ['key', 'GET', 'u4', '0', 'SET', 'u4', '0', 1]);
$this->assertFalse(
$strategy->isReadOperation($command),
'BITFIELD with GET and SET is expected to be a write operation.'
@@ -149,19 +149,19 @@ class ReplicationStrategyTest extends PredisTestCase
$commands = $this->getCommandFactory();
$strategy = new ReplicationStrategy();
$command = $commands->create('GEORADIUS', array('key:geo', 15, 37, 200, 'km'));
$command = $commands->create('GEORADIUS', ['key:geo', 15, 37, 200, 'km']);
$this->assertTrue(
$strategy->isReadOperation($command),
'GEORADIUS is expected to be a read operation.'
);
$command = $commands->create('GEORADIUS', array('key:geo', 15, 37, 200, 'km', 'store', 'key:store'));
$command = $commands->create('GEORADIUS', ['key:geo', 15, 37, 200, 'km', 'store', 'key:store']);
$this->assertFalse(
$strategy->isReadOperation($command),
'GEORADIUS with STORE is expected to be a write operation.'
);
$command = $commands->create('GEORADIUS', array('key:geo', 15, 37, 200, 'km', 'storedist', 'key:storedist'));
$command = $commands->create('GEORADIUS', ['key:geo', 15, 37, 200, 'km', 'storedist', 'key:storedist']);
$this->assertFalse(
$strategy->isReadOperation($command),
'GEORADIUS with STOREDIST is expected to be a write operation.'
@@ -176,19 +176,19 @@ class ReplicationStrategyTest extends PredisTestCase
$commands = $this->getCommandFactory();
$strategy = new ReplicationStrategy();
$command = $commands->create('GEORADIUSBYMEMBER', array('key:geo', 15, 37, 200, 'km'));
$command = $commands->create('GEORADIUSBYMEMBER', ['key:geo', 15, 37, 200, 'km']);
$this->assertTrue(
$strategy->isReadOperation($command),
'GEORADIUSBYMEMBER is expected to be a read operation.'
);
$command = $commands->create('GEORADIUSBYMEMBER', array('key:geo', 15, 37, 200, 'km', 'store', 'key:store'));
$command = $commands->create('GEORADIUSBYMEMBER', ['key:geo', 15, 37, 200, 'km', 'store', 'key:store']);
$this->assertFalse(
$strategy->isReadOperation($command),
'GEORADIUSBYMEMBER with STORE is expected to be a write operation.'
);
$command = $commands->create('GEORADIUSBYMEMBER', array('key:geo', 15, 37, 200, 'km', 'storedist', 'key:storedist'));
$command = $commands->create('GEORADIUSBYMEMBER', ['key:geo', 15, 37, 200, 'km', 'storedist', 'key:storedist']);
$this->assertFalse(
$strategy->isReadOperation($command),
'GEORADIUSBYMEMBER with STOREDIST is expected to be a write operation.'
@@ -278,10 +278,10 @@ class ReplicationStrategyTest extends PredisTestCase
return $command->getArgument(1) === true;
});
$command = $commands->create('SET', array('trigger', false));
$command = $commands->create('SET', ['trigger', false]);
$this->assertFalse($strategy->isReadOperation($command));
$command = $commands->create('SET', array('trigger', true));
$command = $commands->create('SET', ['trigger', true]);
$this->assertTrue($strategy->isReadOperation($command));
}
@@ -298,13 +298,13 @@ class ReplicationStrategyTest extends PredisTestCase
$strategy->setScriptReadOnly($readScript, true);
$cmdEval = $commands->create('EVAL', array($writeScript));
$cmdEvalSHA = $commands->create('EVALSHA', array(sha1($writeScript)));
$cmdEval = $commands->create('EVAL', [$writeScript]);
$cmdEvalSHA = $commands->create('EVALSHA', [sha1($writeScript)]);
$this->assertFalse($strategy->isReadOperation($cmdEval));
$this->assertFalse($strategy->isReadOperation($cmdEvalSHA));
$cmdEval = $commands->create('EVAL', array($readScript));
$cmdEvalSHA = $commands->create('EVALSHA', array(sha1($readScript)));
$cmdEval = $commands->create('EVAL', [$readScript]);
$cmdEvalSHA = $commands->create('EVALSHA', [sha1($readScript)]);
$this->assertTrue($strategy->isReadOperation($cmdEval));
$this->assertTrue($strategy->isReadOperation($cmdEvalSHA));
}
@@ -318,7 +318,7 @@ class ReplicationStrategyTest extends PredisTestCase
/** @var CommandInterface|MockObject */
$command = $this->getMockBuilder('Predis\Command\ScriptCommand')
->onlyMethods(array('getScript'))
->onlyMethods(['getScript'])
->getMock();
$command
->expects($this->any())
@@ -329,10 +329,10 @@ class ReplicationStrategyTest extends PredisTestCase
return $command->getArgument(2) === true;
});
$command->setArguments(array(false));
$command->setArguments([false]);
$this->assertFalse($strategy->isReadOperation($command));
$command->setArguments(array(true));
$command->setArguments([true]);
$this->assertTrue($strategy->isReadOperation($command));
}
@@ -345,14 +345,14 @@ class ReplicationStrategyTest extends PredisTestCase
/** @var CommandInterface|MockObject */
$command = $this->getMockBuilder('Predis\Command\ScriptCommand')
->onlyMethods(array('getScript'))
->getMock(array('getScript'));
->onlyMethods(['getScript'])
->getMock(['getScript']);
$command
->expects($this->any())
->method('getScript')
->willReturn($script = 'return true');
$command->setArguments(array('trigger', false));
$command->setArguments(['trigger', false]);
$strategy->setScriptReadOnly($script, true);
@@ -372,7 +372,7 @@ class ReplicationStrategyTest extends PredisTestCase
*/
protected function getExpectedCommands(?string $type = null): array
{
$commands = array(
$commands = [
/* commands operating on the connection */
'AUTH' => 'read',
'SELECT' => 'read',
@@ -517,7 +517,7 @@ class ReplicationStrategyTest extends PredisTestCase
'GEODIST' => 'read',
'GEORADIUS' => 'variable',
'GEORADIUSBYMEMBER' => 'variable',
);
];
if (isset($type)) {
$commands = array_filter($commands, function (string $expectedType) use ($type) {