diff --git a/src/ClientContextInterface.php b/src/ClientContextInterface.php index 51d6780d..d7e61a3b 100644 --- a/src/ClientContextInterface.php +++ b/src/ClientContextInterface.php @@ -167,6 +167,7 @@ use Predis\Command\CommandInterface; * @method $this unwatch() * @method $this watch($key) * @method $this eval($script, $numkeys, $keyOrArg1 = null, $keyOrArgN = null) + * @method $this eval_ro(string $script, array $keys, ...$argument) * @method $this evalsha($script, $numkeys, $keyOrArg1 = null, $keyOrArgN = null) * @method $this script($subcommand, $argument = null) * @method $this auth($password) diff --git a/src/ClientInterface.php b/src/ClientInterface.php index d9508a66..c560121b 100644 --- a/src/ClientInterface.php +++ b/src/ClientInterface.php @@ -185,6 +185,7 @@ use Predis\Response\Status; * @method mixed unwatch() * @method mixed watch(string $key) * @method mixed eval(string $script, int $numkeys, string ...$keyOrArg = null) + * @method mixed eval_ro(string $script, array $keys, ...$argument) * @method mixed evalsha(string $script, int $numkeys, string ...$keyOrArg = null) * @method mixed script($subcommand, $argument = null) * @method mixed auth(string $password) diff --git a/src/Command/Redis/EVAL_RO.php b/src/Command/Redis/EVAL_RO.php new file mode 100644 index 00000000..cef8bd35 --- /dev/null +++ b/src/Command/Redis/EVAL_RO.php @@ -0,0 +1,34 @@ +getCommand(); + $command->setArguments($arguments); + + $this->assertSame($expected, $command->getArguments()); + } + + /** + * @group disconnected + */ + public function testParseResponse(): void + { + $this->assertSame(1, $this->getCommand()->parseResponse(1)); + } + + /** + * @group connected + * @dataProvider scriptsProvider + * @param array $dictionary + * @param string $script + * @param array $keys + * @param array $arguments + * @param $expectedResponse + * @return void + * @requiresRedisVersion >= 7.0.0 + */ + public function testExecutesReadOnlyCommandsFromGivenLuaScript( + array $dictionary, + string $script, + array $keys, + array $arguments, + $expectedResponse + ): void { + $redis = $this->getClient(); + + $redis->mset(...$dictionary); + + $this->assertSame($expectedResponse, $redis->eval_ro($script, $keys, ...$arguments)); + } + + /** + * @group connected + * @return void + * @requiresRedisVersion >= 7.0.0 + */ + public function testThrowsErrorOnWriteCommandProvided(): void + { + $redis = $this->getClient(); + + $this->expectException(ServerException::class); + $this->expectExceptionMessageMatches('/^ERR Write commands are not allowed from read-only scripts./'); + + $redis->eval_ro("return redis.call('SET', KEYS[1], ARGV[1])", ['key'], 'value'); + } + + public function scriptsProvider(): array + { + return [ + 'with single key' => [ + ['key', 'value'], + "return redis.call('GET', KEYS[1])", + ['key'], + [], + 'value', + ], + 'with multiple keys' => [ + ['key', 'value', 'key1', 2], + "return redis.call('MGET', KEYS[1], KEYS[2])", + ['key', 'key1'], + [], + ['value', '2'], + ], + 'with arguments provided' => [ + ['key', 'mytest', 'key1', 'ourtest'], + "return redis.call('LCS', KEYS[1], KEYS[2], ARGV[1])", + ['key', 'key1'], + ['LEN'], + 4, + ], + ]; + } +}