geckon01/predis
1
0
Fork 0
mirror of https://github.com/predis/predis.git synced 2026-10-09 21:38:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

No need for socket_import_stream() to set TCP_NODELAY since PHP 7.1.

Browse Source
This commit is contained in:
Daniele Alessandri
2020-09-04 17:56:19 +02:00
parent 67487528eb
commit e5f44c33a2
4 changed files with 89 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Predis/Connection/StreamConnectionTest.php
+42
View File
@@ -132,4 +132,46 @@ class StreamConnectionTest extends PredisConnectionTestCase
$this->assertNotSame($connection1->getResource(), $connection2->getResource());
}
/**
* @group connected
*/
public function testTcpNodelayParameterSetsContextFlagWhenTrue()
{
$connection = $this->createConnectionWithParams(['tcp_nodelay' => true]);
$options = stream_context_get_options($connection->getResource());
$this->assertIsArray($options);
$this->assertArrayHasKey('socket', $options);
$this->assertArrayHasKey('tcp_nodelay', $options['socket']);
$this->assertTrue($options['socket']['tcp_nodelay']);
}
/**
* @group connected
*/
public function testTcpNodelayParameterDoesNotSetContextFlagWhenFalse()
{
$connection = $this->createConnectionWithParams(['tcp_nodelay' => false]);
$options = stream_context_get_options($connection->getResource());
$this->assertIsArray($options);
$this->assertArrayHasKey('socket', $options);
$this->assertArrayHasKey('tcp_nodelay', $options['socket']);
$this->assertFalse($options['socket']['tcp_nodelay']);
}
/**
* @group connected
*/
public function testTcpDelayContextFlagIsNotSetByDefault()
{
$connection = $this->createConnectionWithParams([]);
$options = stream_context_get_options($connection->getResource());
$this->assertIsArray($options);
$this->assertArrayHasKey('socket', $options);
$this->assertArrayHasKey('tcp_nodelay', $options['socket']);
$this->assertFalse($options['socket']['tcp_nodelay']);
}
}