* Do not follow -ASK on the first command of a cluster transaction
A cluster transaction is held on the node the slots map associates
with its slot, but its first command went through the cluster like any
other one. While a slot was being migrated, an -ASK reply to WATCH (or
to the first command in CAS mode) was followed to the node importing
the slot, and only then was the connection pinned from the slots map,
which -ASK does not update. WATCH was left on the importing node while
MULTI, the queued commands and EXEC ran on the source node with nothing
watched, so the transaction committed even though the watched key had
changed. When the transaction failed after that WATCH, the cleanup was
sent to the source node and the WATCH on the importing node was never
released, so its dirty flag aborted a later, unrelated transaction sent
over the pooled connection.
The first command is now sent through
RedisCluster::executeCommandOnSlotOwner(), which retries and follows
-MOVED and -READONLY like executeCommand() but returns -ASK replies.
The transaction then fails with a ServerException carrying the -ASK
reply, as later CAS commands already did, without touching the
importing node. Retrying once the migration has finished reaches the
new owner. An -ASK reply to a queued command still aborts the
transaction, as before.
The README no longer claims that the first command is redirected like
any other command, and describes how an -ASK reply fails a transaction.
* Add the cluster ASK fix to the changelog
queryClusterNodeForSlotMap() overrides Retry's default catchable exception
list with [ConnectionException::class]. StreamInitException extends
PredisException directly, so a CLUSTER SLOTS refresh that cannot open a
connection to the node it was redirected to is neither retried nor allowed
to fall back to another node: the fail callback that evicts the unreachable
node never runs, and the exception escapes uncaught.
* feature: Added support for READONLY responses from AWS Elastic Cache
* chore: improve -READONLY handler comment and add changelog entry (#1656)
* tests: add unit test demonstrating ServerException behavior with READONLY error
* Initial work on retries
* Added retry class and test coverage
* Added support for standalone and cluster
* Make TimeoutException instance of CommunicationException
* Added pipeline, trasnaction, replication support
* Fixed broken test
* Marked test as relay-incompatible
* Marked test as relay-incompatible
* Fixed analysis errors, added missing tests
* Codestyle fixes
* Fixed test
* Update README.md
* Update README.md
* Update README.md
* Updated README.md
* Refactor retry on read and write
* Added check for timeout value
* Updated README.md
* Fixed README.md
* Codestyle changes
* Added missing coverage
* Added missing test coverage
* Removed comments
* Added retry support for Relay connection (#1620)
* Added integration test case with mocked retry
* Changed client initialisation in tests
* Marked test as relay-incompatible
---------
Co-authored-by: Pavlo Yatsukhnenko <yatsukhnenko@users.noreply.github.com>
* Added support for redis gears trigger function commands
* Exclude gears tests from relay connection tests
* Codestyle fixes
* Added missing test coverage
* Updated method description
* Use redis-stack:edge image istead of separate container
* Updated RESP3 modules responses
* Removed redundant constants
* Added additional timeout to make sure that index was created
* Marked test as relay-incompatible
* Mark tests as relay-incompatible
* Mark tests as relay-incompatible
* Increase timeout after index creation
* Added support for trigger functions command run against OSS cluster
* Mark gears cluster tests with appropriate annotation
* Marked with cluster annotation
* Codestyle fixes
* Removed refresh cluster on connection, moved to refresh manually in tests
* Removed redundant test
* Updated README, added comments with README references
* Revert "Marked test as relay-incompatible"
This reverts commit d888968b7b.
* Revert changes
* Revert "Mark tests as relay-incompatible"
This reverts commit 7d34370c6b.
* Revert "Updated RESP3 modules responses"
This reverts commit 5cf122ad71.
* Removed latest image
* Updated RESP3 modules responses (#4)
* Marked tests as relay-incompatible (#3)
* Marked test as relay-incompatible
* Mark tests as relay-incompatible
* Mark tests as relay-incompatible
* Changed tests group for RESP3 not supported tests
* Fixed broken tests
* Removed redundant test
* Marked test as relay-incompatible
* Codestyle fixes
* Updated CHANGELOG.md
* Updated CHANGELOG.md
* Revert php-cs-fixer style changes
---------
Co-authored-by: Chayim <chayim@users.noreply.github.com>
* Added support for sharded pub/sub consumer
* Removed query parameter
* Fix typo
* Codestyle fixes
* Added support for sharded pub/sub against DispatcherLoop
* Updated sharded consumer example to subscribe on differend shard channels
* Added test coverage
* Removed cluster condition for pub/sub
* Codestyle fixes
* Changed socket read interface, added parameters as dependency to cluster connection
* Added for interface consistency
* Updated method description
* Updated method description
* Removed redundant exception
* Codestyle fix
* Updated README
* Mark tests as relay-incompatible
* Mark tests as relay-incompatible
* Mark tests as relay-incompatible
* Moved sharded pub/sub functionality to new consumer
* Codestyle fixes
* Resolve context depends on connection type
* Codestyle fixes
* Add complete CI
* Fix CI
* Fix spelling
* Fix indentation
* Fix CI
* Fix CI
* Revert disabling unit tests
* Add coverage driver to CI
* Start coverage debugging
* Fix debugging
ignored, and an empty message aborts the commit.
* Stop debugging
* Move TODO-s from source to GitHub issues
* Ignore too long lines in certain files
* Revert requiring php-parallel-lint/php-parallel-lint
* formatting
* try shorter formatting
* formatting
* fix syntax
* try two paths?
* Update .editorconfig
Co-authored-by: Viktor Szépe <viktor@szepe.net>
* indentation
* make it a group
Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
The "at" matcher will be removed in PHPUnit 10 but it is not a bad thing
after all because it was cumbersome and error-prone.
Took the opportunity to improve some tests while converting them.
- Make use of more typehints for function parameters
- Make use of typehints for function return values
- Use @var where needed to give proper hints to IDEs and avoid warnings
- Replace MockObject::setMethods() with addMethods() and onlyMethods()
- Rewording of some phpdocs
We have renamed most methods to drop the "command" suffix as it is quite
redundant. Due to this change and thanks to variadic methods introduced
with PHP 5.6 we took the opportunity to replace both "supportsCommand()"
and "supportsCommands()" with a single new method "supports()".
Added more stringent typehints for method arguments and typehints for
return values now that we do not need to support anything below PHP 7.2.
Also moved from using array() to [] in source code of class involved.
This change does not affect distribution but simply separates the two
concepts of connection ID (ip:port pair) and alias (value set via the
"alias" connection parameter), the method getConnectionByAlias() has
been added to reflect this change.
The method getConnectionBySlot() has also been added.
In addition to that, the methods askSlotsMap() and buildSlotsMap() of
the redis-cluster connection backend have been renamed respectively
to askSlotMap() and buildSlotMap().