mirror of
https://github.com/predis/predis.git
synced 2026-11-08 19:06:36 +00:00
Sergey Sannikov
3ffaf10e99
parseDouble() fell through to a float cast for ',nan', and
(float) 'nan' evaluates to 0.0 in PHP, so a NaN score silently became
a valid zero. Return NAN instead. The RESP3 specification also notes
that Redis before 7.2 may emit any libc representation of NaN
('-nan', 'NAN', 'nan(char-sequence)') and that clients should handle
them, so those spellings are accepted as well.
The TDigest RESP3 tests asserted 0 or null for empty sketches, which
only passed because of the collapsed 0.0 (null == 0.0 loosely); their
RESP2 counterparts already assert the string 'nan' for the same
replies. They now assert NaN.
Note for reviewers: json_encode() throws on NAN, so consumers who
serialize raw replies must handle it; the previous behavior hid NaN
behind a plausible-looking 0.0 instead.
138 lines
3.2 KiB
PHP
138 lines
3.2 KiB
PHP
<?php
|
|
|
|
/*
|
|
* This file is part of the Predis package.
|
|
*
|
|
* (c) 2009-2020 Daniele Alessandri
|
|
* (c) 2021-2026 Till Krüss
|
|
*
|
|
* For the full copyright and license information, please view the LICENSE
|
|
* file that was distributed with this source code.
|
|
*/
|
|
|
|
namespace Predis\Command\Redis\TDigest;
|
|
|
|
use Predis\Command\PrefixableCommand;
|
|
use Predis\Command\Redis\PredisCommandTestCase;
|
|
use Predis\Response\ServerException;
|
|
|
|
/**
|
|
* @group commands
|
|
* @group realm-stack
|
|
*/
|
|
class TDIGESTMAX_Test extends PredisCommandTestCase
|
|
{
|
|
/**
|
|
* {@inheritDoc}
|
|
*/
|
|
protected function getExpectedCommand(): string
|
|
{
|
|
return TDIGESTMAX::class;
|
|
}
|
|
|
|
/**
|
|
* {@inheritDoc}
|
|
*/
|
|
protected function getExpectedId(): string
|
|
{
|
|
return 'TDIGESTMAX';
|
|
}
|
|
|
|
/**
|
|
* @group disconnected
|
|
*/
|
|
public function testFilterArguments(): void
|
|
{
|
|
$actualArguments = ['key'];
|
|
$expectedArguments = ['key'];
|
|
|
|
$command = $this->getCommand();
|
|
$command->setArguments($actualArguments);
|
|
|
|
$this->assertSameValues($expectedArguments, $command->getArguments());
|
|
}
|
|
|
|
/**
|
|
* @group disconnected
|
|
*/
|
|
public function testParseResponse(): void
|
|
{
|
|
$this->assertSame(1, $this->getCommand()->parseResponse(1));
|
|
}
|
|
|
|
/**
|
|
* @group disconnected
|
|
*/
|
|
public function testPrefixKeys(): void
|
|
{
|
|
/** @var PrefixableCommand $command */
|
|
$command = $this->getCommand();
|
|
$actualArguments = ['arg1'];
|
|
$prefix = 'prefix:';
|
|
$expectedArguments = ['prefix:arg1'];
|
|
|
|
$command->setArguments($actualArguments);
|
|
$command->prefixKeys($prefix);
|
|
|
|
$this->assertSame($expectedArguments, $command->getArguments());
|
|
}
|
|
|
|
/**
|
|
* @group connected
|
|
* @group relay-resp3
|
|
* @return void
|
|
* @requiresRedisBfVersion >= 2.4.0
|
|
*/
|
|
public function testReturnsMaxValueFromGivenSketch(): void
|
|
{
|
|
$redis = $this->getClient();
|
|
|
|
$redis->tdigestcreate('key');
|
|
$redis->tdigestcreate('empty_key');
|
|
|
|
$redis->tdigestadd('key', 3, 2, 4, 5, 1);
|
|
|
|
$actualResponse = $redis->tdigestmax('key');
|
|
|
|
$this->assertEquals('5', $actualResponse);
|
|
$this->assertEquals('nan', $redis->tdigestmax('empty_key'));
|
|
}
|
|
|
|
/**
|
|
* @group connected
|
|
* @group relay-resp3
|
|
* @return void
|
|
* @requiresRedisBfVersion >= 2.6.0
|
|
*/
|
|
public function testReturnsMaxValueFromGivenSketchResp3(): void
|
|
{
|
|
$redis = $this->getResp3Client();
|
|
|
|
$redis->tdigestcreate('key');
|
|
$redis->tdigestcreate('empty_key');
|
|
|
|
$redis->tdigestadd('key', 3, 2, 4, 5, 1);
|
|
|
|
$actualResponse = $redis->tdigestmax('key');
|
|
|
|
$this->assertEquals('5', $actualResponse);
|
|
$this->assertNan($redis->tdigestmax('empty_key'));
|
|
}
|
|
|
|
/**
|
|
* @group connected
|
|
* @group relay-resp3
|
|
* @return void
|
|
* @requiresRedisBfVersion >= 2.4.0
|
|
*/
|
|
public function testThrowsExceptionOnNonExistingTDigestSketch(): void
|
|
{
|
|
$redis = $this->getClient();
|
|
|
|
$this->expectException(ServerException::class);
|
|
$this->expectExceptionMessage('ERR T-Digest: key does not exist');
|
|
|
|
$redis->tdigestmax('key');
|
|
}
|
|
}
|