From 6547c07113b1451a9083473af22b19fbef7514dc Mon Sep 17 00:00:00 2001 From: Simon Sessingo Date: Mon, 20 Nov 2017 21:53:41 +0100 Subject: [PATCH 1/2] Fixed spelling in documentation --- README.md | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index f416e0d..08bc889 100644 --- a/README.md +++ b/README.md @@ -212,17 +212,23 @@ Simply create a new `web.config` file in your projects `public` directory and pa ``` -#### Troubleshoting +#### Troubleshooting -If you do not have a favicon.ico file in your project, you can get `404 Router::notFoundException()` constantly. -To add `favicon.ico` as exception, you can add this line to the `` group: -`````` +If you do not have a `favicon.ico` file in your project, you can get a `NotFoundHttpException` (404 - not found). +To add `favicon.ico` to the IIS ignore-list, add the following line to the `` group: +``` + +``` You can also make one exception for files with some extensions: -`````` +``` + +``` -If you are using `$_SERVER['ORIG_PATH_INFO']`, you will get `\index.php\` as part of the returned value. By sample: -```/index.php/test/mypage.php``` +If you are using `$_SERVER['ORIG_PATH_INFO']`, you will get `\index.php\` as part of the returned value. For example: +``` +/index.php/test/mypage.php +``` ### Configuration From c29c52ae16adaaca1a352cb5e5ba6452bf4fde87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Sessing=C3=B8?= Date: Sat, 25 Nov 2017 01:31:43 +0100 Subject: [PATCH 2/2] Fixed default-namespace causing router to break on closures. --- src/Pecee/SimpleRouter/SimpleRouter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Pecee/SimpleRouter/SimpleRouter.php b/src/Pecee/SimpleRouter/SimpleRouter.php index 2c545a2..c14e47e 100644 --- a/src/Pecee/SimpleRouter/SimpleRouter.php +++ b/src/Pecee/SimpleRouter/SimpleRouter.php @@ -427,7 +427,7 @@ class SimpleRouter $callback = $route->getCallback(); /* Only add default namespace on relative callbacks */ - if ($callback === null || $callback[0] !== '\\') { + if ($callback === null || (is_string($callback) === true && $callback[0] !== '\\')) { $namespace = static::$defaultNamespace;