Development

- Fixed BootManager not loading.
- Optimised for-loops.
This commit is contained in:
Simon Sessingø
2016-11-25 02:27:46 +01:00
parent 7edee8e6d3
commit 2dd2d95af5
5 changed files with 16 additions and 13 deletions

View File

@@ -107,10 +107,10 @@ abstract class LoadableRoute extends Route implements ILoadableRoute
/* Let's parse the values of any {} parameter in the url */
$max = count($params);
$max = count($params) - 1;
$keys = array_keys($params);
for ($i = 0; $i < $max; $i++) {
for ($i = $max; $i >= 0; $i--) {
$param = $keys[$i];
$value = $params[$param];

View File

@@ -77,10 +77,11 @@ abstract class Route implements IRoute
$lastCharacter = '';
$isParameter = false;
$parameter = '';
$routeLength = strlen($route) - 1;
for ($i = 0; $i < strlen($route); $i++) {
for ($i = $routeLength; $i >= 0; $i--) {
$character = $route[$i];
$character = strrev($route)[$i];
if ($character === '{') {
/* Remove "/" and "\" from regex */
@@ -129,9 +130,9 @@ abstract class Route implements IRoute
$parameters = [];
$max = count($parameterNames);
$max = count($parameterNames) - 1;
for ($i = 0; $i < $max; $i++) {
for ($i = $max; $i >= 0; $i--) {
$name = $parameterNames[$i];

View File

@@ -59,6 +59,7 @@ class RouteController extends LoadableRoute implements IControllerRoute
/* Remove requestType from method-name, if it exists */
if ($method !== null) {
$max = count(static::$requestTypes);
for ($i = 0; $i < $max; $i++) {
@@ -70,6 +71,7 @@ class RouteController extends LoadableRoute implements IControllerRoute
break;
}
}
$method .= '/';
}

View File

@@ -20,9 +20,9 @@ class RouteGroup extends Route implements IGroupRoute
{
if (count($this->domains) > 0) {
$max = count($this->domains);
$max = count($this->domains) - 1;
for ($i = 0; $i < $max; $i++) {
for ($i = $max; $i >= 0; $i--) {
$domain = $this->domains[$i];
$parameters = $this->parseParameters($domain, $request->getHost(), '.*');

View File

@@ -216,7 +216,7 @@ class Router
$max = count($this->bootManagers) - 1;
/* @var $manager IRouterBootManager */
for ($i = 0; $i < $max; $i++) {
for ($i = $max; $i >= 0; $i--) {
$manager = $this->bootManagers[$i];
@@ -345,10 +345,10 @@ class Router
*/
public function findRoute($name)
{
$max = count($this->processedRoutes);
$max = count($this->processedRoutes) - 1;
/* @var $route ILoadableRoute */
for ($i = 0; $i < $max; $i++) {
for ($i = $max; $i >= 0; $i--) {
$route = $this->processedRoutes[$i];
@@ -443,10 +443,10 @@ class Router
/* Loop through all the routes to see if we can find a match */
$max = count($this->processedRoutes);
$max = count($this->processedRoutes) - 1;
/* @var $route ILoadableRoute */
for ($i = 0; $i < $max; $i++) {
for ($i = $max; $i >= 0; $i--) {
$route = $this->processedRoutes[$i];