From 846c9e65842e6c48e458bef68f704e8816cd9daa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Sessing=C3=B8?= Date: Sun, 1 Nov 2015 07:36:13 +0100 Subject: [PATCH] [BUGFIX] Optimised getRoute for custom urls. --- src/Pecee/SimpleRouter/RouterBase.php | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/Pecee/SimpleRouter/RouterBase.php b/src/Pecee/SimpleRouter/RouterBase.php index 900d1a4..a8a13a0 100644 --- a/src/Pecee/SimpleRouter/RouterBase.php +++ b/src/Pecee/SimpleRouter/RouterBase.php @@ -253,7 +253,7 @@ class RouterBase { throw new \InvalidArgumentException('Invalid type for getParams. Must be array or null'); } - if($controller === null && $parameters === null && $this->loadedRoute !== null) { + if($controller === null && $parameters === null) { return $this->processUrl($this->loadedRoute, null, $getParams); } @@ -295,7 +295,7 @@ class RouterBase { $method = $tmp[1]; } - if($controller === $c && $route !== null) { + if($controller === $c) { return $this->processUrl($route, $method, $parameters, $getParams); } } @@ -307,7 +307,13 @@ class RouterBase { ArrayUtil::append($url, $parameters); } - return '/' . join('/', $url); + $url = '/' . trim(join('/', $url), '/') . '/'; + + if(is_array($getParams)) { + $url .= '?' . Url::arrayToParams($getParams); + } + + return $url; } public static function getInstance() {