Minor optimisations.

This commit is contained in:
Simon Sessingø
2017-11-10 08:23:15 +01:00
parent 927f8d7b3c
commit 97753f5370
2 changed files with 5 additions and 26 deletions
+2 -1
View File
@@ -15,7 +15,7 @@ class CsrfToken
*/ */
public static function generateToken() public static function generateToken()
{ {
if (function_exists('random_bytes')) { if (function_exists('random_bytes') === true) {
return bin2hex(random_bytes(32)); return bin2hex(random_bytes(32));
} }
@@ -46,6 +46,7 @@ class CsrfToken
/** /**
* Set csrf token cookie * Set csrf token cookie
* Overwrite this method to save the token to another storage like session etc.
* *
* @param $token * @param $token
*/ */
+3 -25
View File
@@ -1,4 +1,5 @@
<?php <?php
namespace Pecee\Http; namespace Pecee\Http;
use Pecee\Http\Input\Input; use Pecee\Http\Input\Input;
@@ -42,13 +43,7 @@ class Request
{ {
$this->headers = []; $this->headers = [];
$max = count($_SERVER) - 1; foreach ($_SERVER as $key => $value) {
$keys = array_keys($_SERVER);
for ($i = $max; $i >= 0; $i--) {
$key = $keys[$i];
$value = $_SERVER[$key];
$this->headers[strtolower($key)] = $value; $this->headers[strtolower($key)] = $value;
$this->headers[strtolower(str_replace('_', '-', $key))] = $value; $this->headers[strtolower(str_replace('_', '-', $key))] = $value;
} }
@@ -167,24 +162,7 @@ class Request
*/ */
public function getHeader($name, $defaultValue = null) public function getHeader($name, $defaultValue = null)
{ {
if (array_key_exists(strtolower($name), $this->headers) === true) { return isset($this->headers[strtolower($name)]) ? $this->headers[strtolower($name)] : $defaultValue;
return $this->headers[strtolower($name)];
}
$max = count($_SERVER) - 1;
$keys = array_keys($_SERVER);
for ($i = $max; $i >= 0; $i--) {
$key = $keys[$i];
$name = $_SERVER[$key];
if ($key === $name) {
return $name;
}
}
return $defaultValue;
} }
/** /**