From bc14790a67fb7a5c37a756ed362a9f26928e7691 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Sessing=C3=B8?= Date: Tue, 15 Nov 2016 03:55:28 +0100 Subject: [PATCH] Updated documentation --- README.md | 11 ++++++++--- src/Pecee/SimpleRouter/RouterBase.php | 6 +++--- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index c511696..44dd782 100644 --- a/README.md +++ b/README.md @@ -49,12 +49,17 @@ This is an example of a basic ```index.php``` file: ```php use \Pecee\SimpleRouter\SimpleRouter; -require_once 'routes.php'; // change this to whatever makes sense in your project +// Load external routes file +require_once 'routes.php'; -// The apps default namespace (so we don't have to specify it each time we use MyController@home) +/* + * The default namespace for route-callbacks, so we don't have to specify it each time. + * Can be overwritten by using the namespace config option. + */ + SimpleRouter::setDefaultNamespace('MyWebsite\Controller'); -// Do the routing +// Start the routing SimpleRouter::start(); ``` diff --git a/src/Pecee/SimpleRouter/RouterBase.php b/src/Pecee/SimpleRouter/RouterBase.php index 9174555..72dc7de 100644 --- a/src/Pecee/SimpleRouter/RouterBase.php +++ b/src/Pecee/SimpleRouter/RouterBase.php @@ -106,7 +106,6 @@ class RouterBase { $mergedSettings = array(); /* @var $route RouterEntry */ - /* @var $group RouterGroup */ for($i = 0; $i < count($routes); $i++) { $route = $routes[$i]; @@ -148,6 +147,7 @@ class RouterBase { if ($route->matchRoute($this->request)) { + /* @var $group RouterGroup */ $group = $route; $mergedSettings = array_merge($settings, $group->getMergeableSettings()); @@ -214,11 +214,11 @@ class RouterBase { $routeNotAllowed = false; - $this->request->rewrite_uri = $this->request->uri; + $this->request->rewrite_uri = $this->request->getUri(); $this->request->setUri($originalUri); $this->request->loadedRoute = $route; - $route->loadMiddleware($this->request); + $this->request->loadedRoute->loadMiddleware($this->request); $this->request->loadedRoute->renderRoute($this->request);