[BUGFIX] Middlewares are no longer loaded on invalid routes

This commit is contained in:
Simon Sessingø
2015-10-27 16:42:39 +01:00
parent c2cf2334e7
commit d3ed3a61b5
3 changed files with 2 additions and 6 deletions
+1
View File
@@ -116,6 +116,7 @@ class RouterBase {
$routeNotAllowed = false; $routeNotAllowed = false;
$this->loadedRoute = $routeMatch; $this->loadedRoute = $routeMatch;
$routeMatch->loadMiddleware($this->request);
$routeMatch->renderRoute($this->request); $routeMatch->renderRoute($this->request);
break; break;
} }
+1 -3
View File
@@ -243,7 +243,7 @@ abstract class RouterEntry {
return new $name(); return new $name();
} }
protected function loadMiddleware(Request $request) { public function loadMiddleware(Request $request) {
if($this->getMiddleware()) { if($this->getMiddleware()) {
$middleware = $this->loadClass($this->getMiddleware()); $middleware = $this->loadClass($this->getMiddleware());
if (!($middleware instanceof Middleware)) { if (!($middleware instanceof Middleware)) {
@@ -256,8 +256,6 @@ abstract class RouterEntry {
} }
public function renderRoute(Request $request) { public function renderRoute(Request $request) {
// Load middleware
$this->loadMiddleware($request);
if(is_object($this->getCallback()) && is_callable($this->getCallback())) { if(is_object($this->getCallback()) && is_callable($this->getCallback())) {
@@ -20,9 +20,6 @@ class RouterResource extends RouterEntry {
} }
public function renderRoute(Request $request) { public function renderRoute(Request $request) {
// Load middleware
$this->loadMiddleware($request);
if(is_object($this->getCallback()) && is_callable($this->getCallback())) { if(is_object($this->getCallback()) && is_callable($this->getCallback())) {
// When the callback is a function // When the callback is a function
call_user_func_array($this->getCallback(), $this->getParameters()); call_user_func_array($this->getCallback(), $this->getParameters());