10 Commits

Author SHA1 Message Date
Graham Campbell 0346c26963 CS fixes 2014-09-27 11:05:51 +01:00
Denis Sokolov 70e23d1c52 TemplateHelper: improve invalid utf8 handling in hhvm 2014-03-31 07:21:53 +03:00
Denis 5f03095fae TemplateHelperTest: enable escabe broken utf8 for 5.3 2014-03-31 07:03:44 +03:00
Graham Campbell fe4666d6fa Skip on hhvm too 2014-03-30 18:30:28 +01:00
Denis Sokolov 35115f7e7f TemplateHelper: silent workaround for 5.3 for d76904a 2014-03-30 18:52:42 +02:00
Denis Sokolov d76904a0d8 TemplateHelper: fix escape with broken utf-8, close #163
If the source file that triggered an exception, had an illegal
UTF-8 sequence (because, for example, it wasn't UTF-8),
when PrettyPageHandler would try to show its source on the screen,
htmlspecialchars would return an empty string, resulting in no
source on the screen.

The workaround at least shows question marks instead of the original
characters. Guessing the correct encoding and reencoding that
to UTF-8 is too much bother at this point,
and the current approach still works well enough to see
where the error is coming from.
2014-03-30 18:39:42 +02:00
filp bcf5fdce7f Add TemplateHelper tests for variable handling 2013-06-25 11:47:16 +01:00
filp a03fbc6bf0 Add test for TemplateHelper::render 2013-06-24 23:53:45 +01:00
filp 88143a5734 Add test for TemplateHelper::slug 2013-06-24 23:43:18 +01:00
filp c68608ccc1 Move template helpers to own class 2013-06-24 23:41:00 +01:00