geckon01/EmailValidator
1
0
Fork 0
mirror of https://github.com/egulias/EmailValidator.git synced 2026-08-27 10:30:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

local part comments

Browse Source
This commit is contained in:
Eduardo Gulias Davis
2020-05-03 15:25:33 +02:00
parent ccade62caa
commit aa0eeae92b
5 changed files with 29 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
EmailValidator/Parser/LocalPart.php
+2 -2
View File
@@ -10,7 +10,7 @@ use Egulias\EmailValidator\Result\InvalidEmail;
use Egulias\EmailValidator\Warning\LocalTooLong;
use Egulias\EmailValidator\Exception\ExpectingATEXT;
use Egulias\EmailValidator\Result\Reason\DotAtStart;
use Egulias\EmailValidator\Exception\UnopenedComment;
use Egulias\EmailValidator\Result\Reason\UnOpenedComment;
class LocalPart extends Parser
{
@@ -43,7 +43,7 @@ class LocalPart extends Parser
if ($this->lexer->token['type'] === EmailLexer::S_CLOSEPARENTHESIS) {
if ($openedParenthesis === 0) {
throw new UnopenedComment();
return new InvalidEmail(new UnOpenedComment(), $this->lexer->token['value']);
}
$openedParenthesis--;
EmailValidator/Result/Reason/UnOpenedComment.php
+16
View File
@@ -0,0 +1,16 @@
<?php
namespace Egulias\EmailValidator\Result\Reason;
class UnOpenedComment implements Reason
{
public function code() : int
{
return 152;
}
public function description(): string
{
return 'Missing openning comment parentheses - https://tools.ietf.org/html/rfc5322#section-3.2.2';
}
}
Tests/EmailValidator/LexerTokensTest.php
+1 -1
View File
@@ -6,6 +6,6 @@ class LexerTokensTest extends TestCase
{
public function testToken()
{
$this->fail("implement");
$this->markTestIncomplete("implement");
}
}
Tests/EmailValidator/Validation/RFCValidationTest.php
+9 -9
View File
@@ -35,12 +35,12 @@ use Egulias\EmailValidator\Exception\ExpectingATEXT;
use Egulias\EmailValidator\Exception\ExpectingDTEXT;
use Egulias\EmailValidator\Validation\RFCValidation;
use Egulias\EmailValidator\Exception\UnclosedComment;
use Egulias\EmailValidator\Exception\UnopenedComment;
use Egulias\EmailValidator\Exception\UnopenedComment as ExceptionUnopenedComment;
use Egulias\EmailValidator\Result\Reason\NoLocalPart;
use Egulias\EmailValidator\Exception\UnclosedQuotedString;
use Egulias\EmailValidator\Result\Reason\UnOpenedComment;
use Egulias\EmailValidator\Result\Reason\DotAtStart as ReasonDotAtStart;
use Egulias\EmailValidator\Result\Reason\ExpectingATEXT as ReasonExpectingATEXT;
use Egulias\EmailValidator\Result\Reason\UnclosedQuotedString as ReasonUnclosedQuotedString;
use Egulias\EmailValidator\Result\Reason\UnclosedQuotedString;
class RFCValidationTest extends TestCase
{
@@ -200,7 +200,7 @@ class RFCValidationTest extends TestCase
[new DotAtEnd(), 'example@localhost.'],
[new DotAtEnd(), 'example.@example.co.uk'],
[new UnclosedComment(), '(example@localhost'],
[new InvalidEmail(new ReasonUnclosedQuotedString(), '"'), '"example@localhost'],
[new InvalidEmail(new UnclosedQuotedString(), '"'), '"example@localhost'],
[
new InvalidEmail(
new ReasonExpectingATEXT('https://tools.ietf.org/html/rfc5322#section-3.2.4 - quoted string should be a unit'),
@@ -208,11 +208,11 @@ class RFCValidationTest extends TestCase
'exa"mple@localhost'
],
[new UnclosedComment(), '(example@localhost'],
[new UnopenedComment(), 'comment)example@localhost'],
[new UnopenedComment(), 'example(comment))@localhost'],
[new UnopenedComment(), 'example@comment)localhost'],
[new UnopenedComment(), 'example@localhost(comment))'],
[new UnopenedComment(), 'example@(comment))example.com'],
[new InvalidEmail(new UnOpenedComment(), ')'), 'comment)example@localhost'],
[new InvalidEmail(new UnOpenedComment(), ')'), 'example(comment))@localhost'],
[new ExceptionUnopenedComment, 'example@comment)localhost'],
[new ExceptionUnopenedComment, 'example@localhost(comment))'],
[new ExceptionUnopenedComment, 'example@(comment))example.com'],
//This was the original. But atext is not allowed after \n
//array(EmailValidator::ERR_EXPECTING_ATEXT, "exampl\ne@example.co.uk"),
[new AtextAfterCFWS(), "exampl\ne@example.co.uk"],
Tests/EmailValidator/Validation/ValitadionTest.php
+1 -1
View File
@@ -8,6 +8,6 @@ class ValidationTest extends TestCase
{
public function testValidationReturnsResult()
{
$this->fail("implement return type Validation");
$this->markTestIncomplete("implement return type Validation");
}
}