Different strategy

Fixed typo in No DNS Record reason

.github/workflows/upload-to-codacy.yml

@@ -8,12 +8,27 @@ on:
 jobs:
   upload:
     runs-on: ubuntu-latest
+    if: >
+      github.event.workflow_run.event == 'pull_request' &&
+      github.event.workflow_run.conclusion == 'success'
     strategy:
       fail-fast: true
     name: upload-coverage
+    
     steps:
+      - name: Setup logs directory
+        run: mkdir -p build/coverage
+
+      - name: Download clover.xml artifact
+        uses: dawidd6/action-download-artifact@v7
+        with:
+          workflow: unit-tests 
+          name: clover.xml
+          path: build/coverage
+
       - name: Upload Coverage to Codacy
         shell: bash
         env:
           CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
-        run: bash <(curl -Ls https://coverage.codacy.com/get.sh) report -r build/logs/clover.xml
+
+        run: bash <(curl -Ls https://coverage.codacy.com/get.sh) report -r build/coverage/clover.xml

README.md

@@ -34,7 +34,7 @@ This library aims to support RFCs:
 * [Spoofchecking](/src/Validation/Extra/SpoofCheckValidation.php) and
 [DNSCheckValidation](/src/Validation/DNSCheckValidation.php) validation
 requires that your PHP system has the
-[PHP Internationalization Libraries](https://php.net/manual/en/book.intl.php) 
+[PHP Internationalization Libraries](https://php.net/manual/en/book.intl.php)
 (also known as PHP Intl)
 
 **Note**: `PHP version upgrades will happen to accomodate to the pace of major
@@ -109,7 +109,6 @@ Validations not present in the RFCs
 1. [SpoofCheckValidation](/src/Validation/Extra/SpoofCheckValidation.php): 
 Will check for multi-utf-8 chars that can signal an erroneous email name.
 
-
 ### How to extend
 
 It's easy! You just need to implement
@@ -126,7 +125,8 @@ Is short and simple and will help a lot.
 (You can find current contributors
 [here](https://github.com/egulias/EmailValidator/graphs/contributors))
 
-As this is a port from another library and work, here are other people related to the previous one:
+As this is a port from another library and work, here are other people related
+to the previous one:
 
 * Ricard Clau [@ricardclau](https://github.com/ricardclau):
 Performance against PHP built-in filter_var (v2 and earlier)

src/Result/Reason/NoDNSRecord.php

@@ -11,6 +11,6 @@ class NoDNSRecord implements Reason
 
     public function description() : string
     {
-        return 'No MX or A DSN record was found for this email';
+        return 'No MX or A DNS record was found for this email';
     }
 }

src/Result/Result.php

@@ -6,22 +6,26 @@ interface Result
 {
     /**
      * Is validation result valid?
+     * 
      */
-    public function isValid() : bool;
+    public function isValid(): bool;
 
     /**
      * Is validation result invalid?
      * Usually the inverse of isValid()
+     * 
      */
-    public function isInvalid() : bool;
+    public function isInvalid(): bool;
 
     /**
      * Short description of the result, human readable.
+     * 
      */
-    public function description() : string;
+    public function description(): string;
 
     /**
      * Code for user land to act upon.
+     * 
      */
-    public function code() : int;
+    public function code(): int;
 }

src/Validation/DNSGetRecordWrapper.php

@@ -15,7 +15,7 @@ class DNSGetRecordWrapper
         // A workaround to fix https://bugs.php.net/bug.php?id=73149
         set_error_handler(
             static function (int $errorLevel, string $errorMessage): never {
-                throw new \RuntimeException("Unable to get DNS record for the host: $errorMessage");
+                throw new \RuntimeException(sprintf('Unable to get DNS record for the host: %s', $errorMessage));
             }
         );
         try {