Compare commits

..

9 Commits

Author SHA1 Message Date
Eduardo Gulias Davis c9be65c290 Different strategy 2024-12-31 16:22:03 +01:00
Eduardo Gulias Davis d164dab97f Polish 2024-12-31 16:18:02 +01:00
Eduardo Gulias Davis e67aa7abef Use different action 2024-12-31 16:02:17 +01:00
Eduardo Gulias Davis d3a88ef157 coverage path 2024-12-31 15:47:39 +01:00
Cari D. Burstein 3bd9c8c802 Update NoDNSRecord.php (#395)
Fixed typo in No DNS Record reason
2024-12-31 15:41:19 +01:00
Eduardo Gulias Davis 8be1dae097 Polish (#400)
* Polish

* polish

* improve workflow

* Fix action usage

* polish

* polish
2024-12-31 15:39:18 +01:00
Eduardo Gulias Davis dcf8f79c41 polish 2024-12-27 23:41:39 +01:00
Eduardo Gulias Davis e30356b45e Fix action usage 2024-12-27 23:22:30 +01:00
Eduardo Gulias Davis 229560066e improve workflow 2024-12-27 23:11:08 +01:00
3 changed files with 7 additions and 3 deletions
+5 -1
View File
@@ -8,6 +8,9 @@ on:
jobs: jobs:
upload: upload:
runs-on: ubuntu-latest runs-on: ubuntu-latest
if: >
github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.conclusion == 'success'
strategy: strategy:
fail-fast: true fail-fast: true
name: upload-coverage name: upload-coverage
@@ -17,8 +20,9 @@ jobs:
run: mkdir -p build/coverage run: mkdir -p build/coverage
- name: Download clover.xml artifact - name: Download clover.xml artifact
uses: actions/download-artifact@v3 uses: dawidd6/action-download-artifact@v7
with: with:
workflow: unit-tests
name: clover.xml name: clover.xml
path: build/coverage path: build/coverage
+1 -1
View File
@@ -11,6 +11,6 @@ class NoDNSRecord implements Reason
public function description() : string public function description() : string
{ {
return 'No MX or A DSN record was found for this email'; return 'No MX or A DNS record was found for this email';
} }
} }
+1 -1
View File
@@ -15,7 +15,7 @@ class DNSGetRecordWrapper
// A workaround to fix https://bugs.php.net/bug.php?id=73149 // A workaround to fix https://bugs.php.net/bug.php?id=73149
set_error_handler( set_error_handler(
static function (int $errorLevel, string $errorMessage): never { static function (int $errorLevel, string $errorMessage): never {
throw new \RuntimeException("Unable to get DNS record for the host: $errorMessage"); throw new \RuntimeException(sprintf('Unable to get DNS record for the host: %s', $errorMessage));
} }
); );
try { try {