geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-05 06:58:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3347 from ConnectGrid/optimize-worksheet-from-array

Browse Source 
Check $strictNullComparison outside of loops
This commit is contained in:
oleibman
2024-10-06 05:01:55 +00:00
committed by GitHub
parent ce16d0d42c 5c6925d08e
commit 457b61cf8d
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PhpSpreadsheet/Worksheet/Worksheet.php
+14 -7
View File
@@ -2784,23 +2784,30 @@ class Worksheet implements IComparable
[$startColumn, $startRow] = Coordinate::coordinateFromString($startCell);
// Loop through $source
foreach ($source as $rowData) {
$currentColumn = $startColumn;
foreach ($rowData as $cellValue) {
if ($strictNullComparison) {
if ($strictNullComparison) {
foreach ($source as $rowData) {
$currentColumn = $startColumn;
foreach ($rowData as $cellValue) {
if ($cellValue !== $nullValue) {
// Set cell value
$this->getCell($currentColumn . $startRow)->setValue($cellValue);
}
} else {
++$currentColumn;
}
++$startRow;
}
} else {
foreach ($source as $rowData) {
$currentColumn = $startColumn;
foreach ($rowData as $cellValue) {
if ($cellValue != $nullValue) {
// Set cell value
$this->getCell($currentColumn . $startRow)->setValue($cellValue);
}
++$currentColumn;
}
++$currentColumn;
++$startRow;
}
++$startRow;
}
return $this;