Merge pull request #2915 from PHPOffice/Performance-Refresh-Row/Column-Dimensions

Minor memory improvement

src/PhpSpreadsheet/ReferenceHelper.php

@@ -316,6 +316,7 @@ class ReferenceHelper
                     $objColumnDimension->setColumnIndex($newReference);
                 }
             }
+
             $worksheet->refreshColumnDimensions();
         }
     }
@@ -339,6 +340,7 @@ class ReferenceHelper
                     $objRowDimension->setRowIndex($newRoweference);
                 }
             }
+
             $worksheet->refreshRowDimensions();
 
             $copyDimension = $worksheet->getRowDimension($beforeRow - 1);

src/PhpSpreadsheet/Worksheet/Worksheet.php

@@ -658,10 +658,8 @@ class Worksheet implements IComparable
      */
     public function refreshColumnDimensions()
     {
-        $currentColumnDimensions = $this->getColumnDimensions();
         $newColumnDimensions = [];
-
-        foreach ($currentColumnDimensions as $objColumnDimension) {
+        foreach ($this->getColumnDimensions() as $objColumnDimension) {
             $newColumnDimensions[$objColumnDimension->getColumnIndex()] = $objColumnDimension;
         }
 
@@ -677,10 +675,8 @@ class Worksheet implements IComparable
      */
     public function refreshRowDimensions()
     {
-        $currentRowDimensions = $this->getRowDimensions();
         $newRowDimensions = [];
-
-        foreach ($currentRowDimensions as $objRowDimension) {
+        foreach ($this->getRowDimensions() as $objRowDimension) {
             $newRowDimensions[$objRowDimension->getRowIndex()] = $objRowDimension;
         }