geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-12 19:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Changes for Scrutinizer

Browse Source 
Two changes to fix minor problems reported by Scrutinizer.
This commit is contained in:
Owen Leibman
2020-11-27 07:16:23 -08:00
parent 1a0aab1a4f
commit 6b4feb6142
2 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/DefinedNameTest.php
+4 -6
View File
@@ -137,12 +137,10 @@ class DefinedNameTest extends TestCase
$namedRange = $this->spreadsheet->getDefinedName('XYZ');
self::assertInstanceOf(NamedRange::class, $namedRange);
if ($namedRange instanceof NamedRange) {
self::assertEquals('A1', $namedRange->getRange());
self::assertEquals('A1', $namedRange->getValue());
$namedRange->setRange('A2');
self::assertEquals('A2', $namedRange->getValue());
}
self::assertEquals('A1', $namedRange->getRange());
self::assertEquals('A1', $namedRange->getValue());
$namedRange->setRange('A2');
self::assertEquals('A2', $namedRange->getValue());
}
public function testChangeWorksheet(): void
tests/PhpSpreadsheetTests/IOFactoryTest.php
+1 -1
View File
@@ -200,6 +200,6 @@ class IOFactoryTest extends TestCase
{
$this->expectException(\PhpOffice\PhpSpreadsheet\Reader\Exception::class);
$filename = __FILE__;
$reader = IOFactory::createReaderForFile($filename);
IOFactory::createReaderForFile($filename);
}
}