geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-05 06:58:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make boolean check case-insensitive

Browse Source
This commit is contained in:
MarkBaker
2023-02-17 13:14:20 +01:00
parent 5072ffb23a
commit 6ca7ec5d5b
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PhpSpreadsheet/Cell/AdvancedValueBinder.php
+2 -2
View File
@@ -34,11 +34,11 @@ class AdvancedValueBinder extends DefaultValueBinder implements IValueBinder
// Style logic - strings
if ($dataType === DataType::TYPE_STRING && !$value instanceof RichText) {
// Test for booleans using locale-setting
if ($value == Calculation::getTRUE()) {
if (StringHelper::strToUpper($value) === Calculation::getTRUE()) {
$cell->setValueExplicit(true, DataType::TYPE_BOOL);
return true;
} elseif ($value == Calculation::getFALSE()) {
} elseif (StringHelper::strToUpper($value) === Calculation::getFALSE()) {
$cell->setValueExplicit(false, DataType::TYPE_BOOL);
return true;
tests/PhpSpreadsheetTests/Cell/AdvancedValueBinderTest.php
+6
View File
@@ -72,6 +72,12 @@ class AdvancedValueBinderTest extends TestCase
$sheet->getCell('A2')->setValue(false);
self::assertFalse($sheet->getCell('A2')->getValue());
$sheet->getCell('A3')->setValue('true');
self::assertTrue($sheet->getCell('A3')->getValue());
$sheet->getCell('A4')->setValue('false');
self::assertFalse($sheet->getCell('A4')->getValue());
$spreadsheet->disconnectWorksheets();
}