geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-16 21:16:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate Dead Code

Browse Source
This commit is contained in:
oleibman
2025-02-15 20:05:19 -08:00
parent ec773bbed9
commit 7f0bcb8aca
7 changed files with 28 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/Cell/HyperlinkTest.php
+2 -2
View File
@@ -25,7 +25,7 @@ class HyperlinkTest extends TestCase
$newUrlValue = 'http://github.com/PHPOffice/PhpSpreadsheet';
$testInstance = new Hyperlink($initialUrlValue);
$result = $testInstance->setUrl($newUrlValue);
$testInstance->setUrl($newUrlValue);
$result = $testInstance->getUrl();
self::assertEquals($newUrlValue, $result);
@@ -47,7 +47,7 @@ class HyperlinkTest extends TestCase
$newTooltipValue = 'PhpSpreadsheet Repository on Github';
$testInstance = new Hyperlink('', $initialTooltipValue);
$result = $testInstance->setTooltip($newTooltipValue);
$testInstance->setTooltip($newTooltipValue);
$result = $testInstance->getTooltip();
self::assertEquals($newTooltipValue, $result);
tests/PhpSpreadsheetTests/Reader/Ods/OdsTest.php
-2
View File
@@ -54,8 +54,6 @@ class OdsTest extends TestCase
{
$spreadsheet = $this->loadDataFile();
self::assertEquals(2, $spreadsheet->getSheetCount());
$firstSheet = $spreadsheet->getSheet(0);
$secondSheet = $spreadsheet->getSheet(1);
self::assertEquals('Sheet1', $spreadsheet->getSheet(0)->getTitle());
self::assertEquals('Second Sheet', $spreadsheet->getSheet(1)->getTitle());
$spreadsheet->disconnectWorksheets();
tests/PhpSpreadsheetTests/Worksheet/AutoFilter/AutoFilterTest.php
+12 -12
View File
@@ -72,10 +72,10 @@ class AutoFilterTest extends SetupTeardown
foreach ($ranges as $actualRange => $fullRange) {
// Setters return the instance to implement the fluent interface
$result = $autoFilter->setRange($fullRange);
$temp = $autoFilter->setRange($fullRange);
// Result should be the new autofilter range
$result = $autoFilter->getRange();
$result = $temp->getRange();
self::assertEquals($actualRange, $result);
}
}
@@ -88,10 +88,10 @@ class AutoFilterTest extends SetupTeardown
$autoFilter->setRange(self::INITIAL_RANGE);
// Setters return the instance to implement the fluent interface
$result = $autoFilter->setRange('');
$temp = $autoFilter->setRange('');
// Result should be a clear range
$result = $autoFilter->getRange();
$result = $temp->getRange();
self::assertEquals($expectedResult, $result);
}
@@ -223,9 +223,9 @@ class AutoFilterTest extends SetupTeardown
$autoFilter->setRange(self::INITIAL_RANGE);
// Setters return the instance to implement the fluent interface
$result = $autoFilter->setColumn($expectedResult);
$temp = $autoFilter->setColumn($expectedResult);
$result = $autoFilter->getColumns();
$result = $temp->getColumns();
// Result should be an array of \PhpOffice\PhpSpreadsheet\Worksheet\Worksheet\AutoFilter\Column
// objects for each column we set indexed by the column ID
self::assertCount(1, $result);
@@ -253,9 +253,9 @@ class AutoFilterTest extends SetupTeardown
$autoFilter->setRange(self::INITIAL_RANGE);
// Setters return the instance to implement the fluent interface
$result = $autoFilter->setColumn($columnObject);
$temp = $autoFilter->setColumn($columnObject);
$result = $autoFilter->getColumns();
$result = $temp->getColumns();
// Result should be an array of \PhpOffice\PhpSpreadsheet\Worksheet\Worksheet\AutoFilter\Column
// objects for each column we set indexed by the column ID
self::assertCount(1, $result);
@@ -374,10 +374,10 @@ class AutoFilterTest extends SetupTeardown
}
// Setters return the instance to implement the fluent interface
$result = $autoFilter->setRange('');
$temp = $autoFilter->setRange('');
// Range should be cleared
$result = $autoFilter->getRange();
$result = $temp->getRange();
self::assertEquals($expectedResult, $result);
// Column array should be cleared
@@ -404,10 +404,10 @@ class AutoFilterTest extends SetupTeardown
}
// Setters return the instance to implement the fluent interface
$result = $autoFilter->setRange($expectedResult);
$temp = $autoFilter->setRange($expectedResult);
// Range should be correctly set
$result = $autoFilter->getRange();
$result = $temp->getRange();
self::assertEquals($expectedResult, $result);
// Only columns that existed in the original range and that
tests/PhpSpreadsheetTests/Worksheet/AutoFilter/ColumnTest.php
+4 -4
View File
@@ -75,7 +75,7 @@ class ColumnTest extends SetupTeardown
$columnFilter = $sheet->getAutoFilter()->getColumn('H');
// Setters return the instance to implement the fluent interface
$result = $columnFilter->setParent(null);
self::assertSame('filters', $columnFilter->getFilterType());
self::assertSame('filters', $result->getFilterType());
}
public function testVariousSets(): void
@@ -91,7 +91,7 @@ class ColumnTest extends SetupTeardown
$result = $columnFilter->setFilterType(Column::AUTOFILTER_FILTERTYPE_DYNAMICFILTER);
$result = $columnFilter->getFilterType();
$result = $result->getFilterType();
self::assertEquals(Column::AUTOFILTER_FILTERTYPE_DYNAMICFILTER, $result);
$result = $columnFilter->setJoin(Column::AUTOFILTER_COLUMN_JOIN_AND);
@@ -153,7 +153,7 @@ class ColumnTest extends SetupTeardown
$result = $columnFilter->setAttributes($attributeSet);
$result = $columnFilter->getAttributes();
$result = $result->getAttributes();
self::assertSame($attributeSet, $result);
}
@@ -177,7 +177,7 @@ class ColumnTest extends SetupTeardown
// Setters return the instance to implement the fluent interface
$result = $columnFilter->setAttribute($attributeName, $attributeValue);
}
self::assertSame($attributeSet, $columnFilter->getAttributes());
self::assertSame($attributeSet, $result->getAttributes());
}
public function testGetAttribute(): void
tests/PhpSpreadsheetTests/Worksheet/Table/ColumnTest.php
+1 -1
View File
@@ -63,7 +63,7 @@ class ColumnTest extends SetupTeardown
$column = $table->getColumn('H');
$result = $column->setShowFilterButton(false);
self::assertFalse($column->getShowFilterButton());
self::assertFalse($result->getShowFilterButton());
$label = 'Total';
$result = $column->setTotalsRowLabel($label);
tests/PhpSpreadsheetTests/Worksheet/Table/TableStyleTest.php
+1 -1
View File
@@ -17,7 +17,7 @@ class TableStyleTest extends SetupTeardown
$style = $table->getStyle();
$result = $style->setTheme(TableStyle::TABLE_STYLE_DARK1);
self::assertEquals(TableStyle::TABLE_STYLE_DARK1, $style->getTheme());
self::assertEquals(TableStyle::TABLE_STYLE_DARK1, $result->getTheme());
$result = $style->setShowFirstColumn(true);
self::assertTrue($style->getShowFirstColumn());
tests/PhpSpreadsheetTests/Worksheet/Table/TableTest.php
+8 -8
View File
@@ -33,7 +33,7 @@ class TableTest extends SetupTeardown
$table = new Table(self::INITIAL_RANGE);
$result = $table->setName($name);
self::assertEquals($expected, $table->getName());
self::assertEquals($expected, $result->getName());
}
public static function validTableNamesProvider(): array
@@ -113,7 +113,7 @@ class TableTest extends SetupTeardown
$table = new Table(self::INITIAL_RANGE);
$result = $table->setShowHeaderRow(false);
self::assertFalse($table->getShowHeaderRow());
self::assertFalse($result->getShowHeaderRow());
$result = $table->setShowTotalsRow(true);
self::assertTrue($table->getShowTotalsRow());
@@ -156,7 +156,7 @@ class TableTest extends SetupTeardown
$table = new Table(self::INITIAL_RANGE);
$result = $table->setRange($fullRange);
self::assertEquals($actualRange, $table->getRange());
self::assertEquals($actualRange, $result->getRange());
}
public function testSetRangeValidRange(): void
@@ -188,7 +188,7 @@ class TableTest extends SetupTeardown
$result = $table->setRange('');
// Result should be a clear range
$result = $table->getRange();
$result = $result->getRange();
self::assertEquals($expectedResult, $result);
}
@@ -313,7 +313,7 @@ class TableTest extends SetupTeardown
// Setters return the instance to implement the fluent interface
$result = $table->setColumn($expectedResult);
$result = $table->getColumns();
$result = $result->getColumns();
// Result should be an array of \PhpOffice\PhpSpreadsheet\Worksheet\Worksheet\Table\Column
// objects for each column we set indexed by the column ID
self::assertCount(1, $result);
@@ -338,7 +338,7 @@ class TableTest extends SetupTeardown
// Setters return the instance to implement the fluent interface
$result = $table->setColumn($columnObject);
$result = $table->getColumns();
$result = $result->getColumns();
// Result should be an array of \PhpOffice\PhpSpreadsheet\Worksheet\Worksheet\Table\Column
// objects for each column we set indexed by the column ID
self::assertCount(1, $result);
@@ -446,7 +446,7 @@ class TableTest extends SetupTeardown
$result = $table->setRange('');
// Range should be cleared
$result = $table->getRange();
$result = $result->getRange();
self::assertEquals($expectedResult, $result);
// Column array should be cleared
@@ -474,7 +474,7 @@ class TableTest extends SetupTeardown
$result = $table->setRange($expectedResult);
// Range should be correctly set
$result = $table->getRange();
$result = $result->getRange();
self::assertEquals($expectedResult, $result);
// Only columns that existed in the original range and that