geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-06 15:52:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Found an Untested String Increment Operator

Browse Source
This commit is contained in:
oleibman
2025-09-16 13:00:09 -07:00
parent acba6d1f4a
commit 9bb090d64e
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PhpSpreadsheet/Writer/Ods/Settings.php
+2 -1
View File
@@ -5,6 +5,7 @@ namespace PhpOffice\PhpSpreadsheet\Writer\Ods;
use Composer\Pcre\Preg;
use PhpOffice\PhpSpreadsheet\Cell\CellAddress;
use PhpOffice\PhpSpreadsheet\Cell\Coordinate;
use PhpOffice\PhpSpreadsheet\Shared\StringHelper;
use PhpOffice\PhpSpreadsheet\Shared\XMLWriter;
use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
@@ -137,7 +138,7 @@ class Settings extends WriterPart
$this->writeSplitValue($objWriter, 'PositionLeft', 'short', '0');
$this->writeSplitValue($objWriter, 'PositionRight', 'short', (string) ($columnId - 1));
for ($column = 'A'; $column !== $columnName; ++$column) {
for ($column = 'A'; $column !== $columnName; StringHelper::stringIncrement($column)) {
$worksheet->getColumnDimension($column)->setAutoSize(true);
}
tests/PhpSpreadsheetTests/Writer/Ods/FreezeTest.php
+5 -5
View File
@@ -19,20 +19,20 @@ class FreezeTest extends TestCase
['A', 'B', 'C', 'D'],
[1, 2, 3, 4],
]);
$sheet->freezePane('A2');
$sheet->freezePane('B2');
$writer = new OdsWriter($spreadsheet);
$writerSettings = new OdsWriter\Settings($writer);
$settings = $writerSettings->write();
// The items we are particular interested in below are:
// HorizontalSplitMode, HorizontalSplitPosition
// VerticalSplitMode, VerticalSplitPosition
// HorizontalSplitMode, HorizontalSplitPosition, PositionLeft, PositionRight
// VerticalSplitMode, VerticalSplitPosition, PositionTop, PositionBottom
$expected = '<config:config-item-map-entry config:name="Worksheet">'
. '<config:config-item config:name="CursorPositionX" config:type="int">0</config:config-item>'
. '<config:config-item config:name="CursorPositionY" config:type="int">0</config:config-item>'
. '<config:config-item config:name="HorizontalSplitMode" config:type="short">2</config:config-item>'
. '<config:config-item config:name="HorizontalSplitPosition" config:type="int">0</config:config-item>'
. '<config:config-item config:name="HorizontalSplitPosition" config:type="int">1</config:config-item>'
. '<config:config-item config:name="PositionLeft" config:type="short">0</config:config-item>'
. '<config:config-item config:name="PositionRight" config:type="short">0</config:config-item>'
. '<config:config-item config:name="PositionRight" config:type="short">1</config:config-item>'
. '<config:config-item config:name="VerticalSplitMode" config:type="short">2</config:config-item>'
. '<config:config-item config:name="VerticalSplitPosition" config:type="int">1</config:config-item>'
. '<config:config-item config:name="PositionTop" config:type="short">0</config:config-item>'