geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-17 21:46:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Php 8.4 Change Affects Test

Browse Source 
mime_content_type will recognize files as text/csv rather than text/html.
This commit is contained in:
oleibman
2024-05-24 21:00:25 -07:00
parent 2833ddc22d
commit a51d3541c0
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/Reader/Csv/NotHtmlTest.php
+14 -2
View File
@@ -36,7 +36,13 @@ class NotHtmlTest extends TestCase
fwrite($handle, "{$row[0]},{$row[1]},{$row[2]}\n");
}
fclose($handle);
self::assertSame('text/html', mime_content_type($filename));
// Php8.3- identify file as text/html.
// Php8.4+ identify file as text/csv, and this type of change
// has been known to be retrofitted to prior versions.
$mime = mime_content_type($filename);
if ($mime !== 'text/csv') {
self::assertSame('text/html', $mime);
}
self::assertSame('Csv', IOFactory::identify($filename));
$reader = new CsvReader();
$spreadsheet = $reader->load($filename);
@@ -60,7 +66,13 @@ class NotHtmlTest extends TestCase
fwrite($handle, "{$row[0]},{$row[1]},{$row[2]}\n");
}
fclose($handle);
self::assertSame('text/html', mime_content_type($filename));
// Php8.3- identify file as text/html.
// Php8.4+ identify file as text/csv, and this type of change
// has been known to be retrofitted to prior versions.
$mime = mime_content_type($filename);
if ($mime !== 'text/csv') {
self::assertSame('text/html', $mime);
}
self::assertSame('Html', IOFactory::identify($filename));
$reader = new CsvReader();
$spreadsheet = $reader->load($filename);