mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-14 20:16:34 +00:00
removeColumn doesn't remove all cells
removeColumn doesn't remove all cells, because CacheBase::deleteCacheData only unsets cell data if they are objects. But cached cell data could be arrays. I moved the unset from inside the if block (line 150 ff) to after the if block.
This commit is contained in:
committed by
Adrien Crivelli
parent
3b4f54722f
commit
c1f5bdba5d
@@ -147,8 +147,8 @@ abstract class CacheBase
|
||||
|
||||
if (is_object($this->cellCache[$pCoord])) {
|
||||
$this->cellCache[$pCoord]->detach();
|
||||
unset($this->cellCache[$pCoord]);
|
||||
}
|
||||
unset($this->cellCache[$pCoord]);
|
||||
$this->currentCellIsDirty = false;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user