geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-14 12:06:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: using function count instead

Browse Source
This commit is contained in:
Denny Septian Panggabean
2025-06-02 11:34:42 +07:00
committed by GitHub
parent ea6ed77fdd
commit ca12ffd6ef
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PhpSpreadsheet/Spreadsheet.php
+4 -5
View File
@@ -608,7 +608,7 @@ class Spreadsheet implements JsonSerializable
*/
public function removeSheetByIndex(int $sheetIndex): void
{
$numSheets = count($this->workSheetCollection);
$numSheets = $this->getSheetCount();
if ($sheetIndex > $numSheets - 1) {
throw new Exception(
"You tried to remove a sheet by the out of bounds index: {$sheetIndex}. The actual number of sheets is {$numSheets}."
@@ -660,10 +660,9 @@ class Spreadsheet implements JsonSerializable
*/
public function getSheetByName(string $worksheetName): ?Worksheet
{
$worksheetCount = count($this->workSheetCollection);
$trimWorksheetName = trim($worksheetName, "'");
for ($i = 0; $i < $worksheetCount; ++$i) {
for ($i = 0; $i < $this->getSheetCount(); ++$i) {
if (strcasecmp($this->workSheetCollection[$i]->getTitle(), $trimWorksheetName) === 0) {
return $this->workSheetCollection[$i];
}
@@ -792,8 +791,8 @@ class Spreadsheet implements JsonSerializable
public function getSheetNames(): array
{
$returnValue = [];
$worksheetCount = $this->getSheetCount();
for ($i = 0; $i < $worksheetCount; ++$i) {
for ($i = 0; $i < $this->getSheetCount(); ++$i) {
$returnValue[] = $this->getSheet($i)->getTitle();
}