geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-08-31 04:28:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove Redundant Tests

Browse Source
This commit is contained in:
oleibman
2026-01-18 12:25:17 -08:00
parent db8f3d2669
commit e1a72c1631
2 changed files with 11 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/Cell/DefaultValueBinderTest.php
+11 -14
View File
@@ -38,7 +38,7 @@ class DefaultValueBinderTest extends TestCase
}
/**
* @return array<string, array{mixed, string}>
* @return array<string, array{0: mixed, 1:string, 2?: mixed}>
*/
public static function binderProvider(): array
{
@@ -58,11 +58,14 @@ class DefaultValueBinderTest extends TestCase
// Booleans
'true' => [true, DataType::TYPE_BOOL],
'false' => [false, DataType::TYPE_BOOL],
'bool-like string' => ['false', DataType::TYPE_STRING],
// Integers
'integer zero' => [0, DataType::TYPE_NUMERIC],
'positive integer' => [42, DataType::TYPE_NUMERIC],
'negative integer' => [-100, DataType::TYPE_NUMERIC],
'trailing newline ignored, probably an error' => ["123456\n", DataType::TYPE_NUMERIC, 123456],
'trailing space' => ['123456 ', DataType::TYPE_STRING],
// Very large integers treated as string to prevent precision loss
'large positive' => [1_000_000_000_000_000, DataType::TYPE_STRING, '1000000000000000'],
@@ -82,7 +85,10 @@ class DefaultValueBinderTest extends TestCase
// Numeric strings
'numeric string integer' => ['123', DataType::TYPE_NUMERIC, 123],
'numeric string float' => ['123.25', DataType::TYPE_NUMERIC, 123.25],
'scientific notation' => ['1.5e10', DataType::TYPE_NUMERIC, 1.5E10],
'scientific notation 1' => ['1.5e10', DataType::TYPE_NUMERIC, 1.5E10],
'issue 4766 very large positive exponent' => ['4E433', DataType::TYPE_STRING],
'issue 4766 scientific large negative exponent' => ['6E-444', DataType::TYPE_NUMERIC, 0.0],
'issue 4766 small exponent no decimal point numeric' => ['4E4', DataType::TYPE_NUMERIC, 4E4],
'negative numeric string' => ['-42.5', DataType::TYPE_NUMERIC, -42.5],
// Valid formulas
@@ -95,6 +101,9 @@ class DefaultValueBinderTest extends TestCase
// Invalid formulas (treated as strings)
'equals only' => ['=', DataType::TYPE_STRING],
'equals with space' => ['= ', DataType::TYPE_STRING],
'Issue 1310 Multiple = at start' => ['======', DataType::TYPE_STRING],
'Issue 1310 Variant 1' => ['= =====', DataType::TYPE_STRING],
'Issue 1310 Variant 2' => ['=2*3=', DataType::TYPE_STRING],
// Error codes
'error NULL' => ['#NULL!', DataType::TYPE_ERROR],
@@ -152,18 +161,6 @@ class DefaultValueBinderTest extends TestCase
$spreadsheet->disconnectWorksheets();
}
#[DataProvider('providerDataTypeForValue')]
public function testDataTypeForValue(mixed $expectedResult, mixed $value): void
{
$result = DefaultValueBinder::dataTypeForValue($value);
self::assertEquals($expectedResult, $result);
}
public static function providerDataTypeForValue(): array
{
return require 'tests/data/Cell/DefaultValueBinder.php';
}
public function testCanOverrideStaticMethodWithoutOverridingBindValue(): void
{
$spreadsheet = new Spreadsheet();
tests/data/Cell/DefaultValueBinder.php
-92
View File
@@ -1,92 +0,0 @@
<?php
declare(strict_types=1);
return [
[
'null',
null,
],
[
'e',
'#NULL!',
],
[
'b',
false,
],
[
'b',
true,
],
[
's',
'FALSE',
],
[
's',
'TRUE',
],
[
's',
'',
],
[
's',
'ABC',
],
[
'n',
'123',
],
[
'n',
123,
],
[
'n',
0.123,
],
[
'n',
'-123',
],
[
'n',
'1.23E4',
],
[
'n',
'-1.23E4',
],
[
'n',
'1.23E-4',
],
[
's',
'000123',
],
[
'f',
'=123',
],
[
'e',
'#DIV/0!',
],
[
's',
'123456\n',
],
'Numeric that exceeds PHP MAX_INT Size' => [
's',
'1234567890123459012345689012345690',
],
'Issue 1310 Multiple = at start' => ['s', '======'],
'Issue 1310 Variant 1' => ['s', '= ====='],
'Issue 1310 Variant 2' => ['s', '=2*3='],
'Issue 4766 very large positive exponent treated as string' => ['s', '4E433'],
'Issue 4766 very large negative exponent numeric' => ['n', '4E-433'],
'Issue 4766 small exponent no decimal point numeric' => ['n', '4E4'],
];