geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-10 10:06:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix PHPStan type safety issues in DimensionsRecordTest

Browse Source 
Add proper type assertions to handle potential false returns:
- Assert file_get_contents() returns string, not false
- Assert strpos() returns int, not false
- Assert unpack() returns array, not false

This resolves all 7 PHPStan errors reported in CI while maintaining
test functionality (12 assertions, all passing).
This commit is contained in:
Nebojša Zlatanović
2025-10-17 13:35:12 +02:00
parent b9857e53d5
commit f2ea8b6cb9
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/Writer/Xls/DimensionsRecordTest.php
+6 -2
View File
@@ -45,13 +45,14 @@ class DimensionsRecordTest extends TestCase
// Read the binary file and find the DIMENSIONS record
$fileContent = file_get_contents($filename);
self::assertIsString($fileContent, 'Failed to read XLS file');
unlink($filename);
// Find the DIMENSIONS record: 0x0200 (2 bytes) + length 0x000E (2 bytes)
$recordSignature = pack('v', 0x0200) . pack('v', 0x000E);
$pos = strpos($fileContent, $recordSignature);
self::assertNotFalse($pos, 'DIMENSIONS record not found in XLS file');
self::assertIsInt($pos, 'DIMENSIONS record not found in XLS file');
// Parse the DIMENSIONS record (skip 4-byte header)
$dataPos = $pos + 4;
@@ -59,6 +60,7 @@ class DimensionsRecordTest extends TestCase
// Unpack DIMENSIONS record
$data = unpack('VrwMic/VrwMac/vcolMic/vcolMac/vreserved', $dimensionsData);
self::assertIsArray($data, 'Failed to unpack DIMENSIONS record');
// Verify the values are correct (0-based for columns, 1-based for rows)
// First used row is 1
@@ -100,13 +102,14 @@ class DimensionsRecordTest extends TestCase
// Read the binary file and find the DIMENSIONS record
$fileContent = file_get_contents($filename);
self::assertIsString($fileContent, 'Failed to read XLS file');
unlink($filename);
// Find the DIMENSIONS record: 0x0200 (2 bytes) + length 0x000E (2 bytes)
$recordSignature = pack('v', 0x0200) . pack('v', 0x000E);
$pos = strpos($fileContent, $recordSignature);
self::assertNotFalse($pos, 'DIMENSIONS record not found in XLS file');
self::assertIsInt($pos, 'DIMENSIONS record not found in XLS file');
// Parse the DIMENSIONS record (skip 4-byte header)
$dataPos = $pos + 4;
@@ -114,6 +117,7 @@ class DimensionsRecordTest extends TestCase
// Unpack DIMENSIONS record
$data = unpack('VrwMic/VrwMac/vcolMic/vcolMac/vreserved', $dimensionsData);
self::assertIsArray($data, 'Failed to unpack DIMENSIONS record');
// Last column should be capped at 256 (255 + 1 for "last used + 1")
// The min(255, ...) ensures we don't exceed the BIFF8 limit