b1eb0e2fef
More unit tests for MMULT() function, to ensure correct calculation compared to using array arguments with the multiplication operator
2022-03-09 17:52:54 +01:00
8ed2bab963
Modifications to FORMULATEXT() to return correct values for cells in array formula (wrapped in {} braces) and for cells within the spillage area of an array formula that should return the arra formula even though they're not the actual formula cell
2022-03-09 17:52:54 +01:00
96453e0ad0
Fix to identify spillage cells from their arrayFormulaRange value
2022-03-09 13:51:55 +01:00
6b0d724a53
Additional unit tests for array operations (in preparation for a switch away from using Jama for handling matrix operations)
2022-03-07 16:10:17 +01:00
ec6113eee3
Merge branch 'master' into CalculationEngine-Array-Formulae-Initial-Work
...
# Conflicts:
# src/PhpSpreadsheet/Calculation/Calculation.php
2022-03-06 14:51:37 +01:00
ee1e56d8e7
Merge pull request #2653 from PHPOffice/CalcEngine-Debug-Log-Test
...
Unit test for the Calculation Engine debug log; and switch to using `sprintf()` rather than concatenation for debug messages
2022-03-06 11:12:53 +01:00
a8f473e9f4
Switch to using sprintf() rather than concatenation for all calculation engine debug logging
2022-03-06 10:51:54 +01:00
044836b426
Unit test for the Calculation Engine debug log
2022-03-06 09:47:17 +01:00
ac33bd9010
Merge pull request #2652 from PHPOffice/Gnumeric-Selected-Cells-in-Worksheet
...
Set Selected Cells for Worksheets in Gnumeric Loader
2022-03-05 19:41:54 +01:00
dbf25f0721
Set Selected Cells for Worksheets in Gnumeric Loader
2022-03-05 19:24:21 +01:00
9c99f2f210
Fix arguments for calculation call in anchorarray() pseudo-functin
2022-03-05 16:52:29 +01:00
5346776cd6
Merge branch 'master' into CalculationEngine-Array-Formulae-Initial-Work
2022-03-05 16:37:57 +01:00
4a562617cc
Reverse $asArray and $resetLog arguments for calcuation methods; $asArray should have priority as a userland argument, whereas $resetLog is primarily for developer debugging
2022-03-05 15:59:34 +01:00
86f2684615
Merge pull request #2651 from PHPOffice/Issue-1971_Failing-to-correctly-escape-double-quotes-in-subformulae
...
Escape double quotes in a string value unless it's an empty string value
2022-03-05 12:50:24 +01:00
cba0e13b2a
Escape double quotes in a string value unless it's an empty string value
2022-03-05 12:44:44 +01:00
51453db41e
Merge pull request #2650 from PHPOffice/Changelog-Updates
...
Minor updates to the change log
2022-03-05 11:14:09 +01:00
16ad02bca8
Minor updates to te change log
2022-03-05 10:56:14 +01:00
85130dcdce
Precision in unit test float value
2022-03-05 10:44:24 +01:00
d6b6a110ec
Additional array formula tests for Ods Reader
2022-03-05 10:37:43 +01:00
b67841a3dd
Additional Gnumeric Reader array formula unit tests
2022-03-04 23:07:11 +01:00
3dbc7ddd25
Handle aray formulae in the Gnumeric Reader (with unit tests)
2022-03-04 22:09:46 +01:00
e4b7d73a9a
Unit tests for reading array formulae in Ods files
2022-03-04 22:09:45 +01:00
fcc55a703b
Fix for calculating array operations in the calculation engine (with tests)
2022-03-04 22:09:45 +01:00
c0f5a403ce
Suppress tests that we know will fail (for the moment)
2022-03-04 16:12:14 +01:00
2c95f3a9f8
Merge branch 'master' into CalculationEngine-Array-Formulae-Initial-Work
2022-03-04 14:59:27 +01:00
7f79e7a17c
Merge pull request #2644 from PHPOffice/CalcEngine-Refactor-Branch-Pruning
...
Initial work on refactoring branch pruning logic
2022-03-04 14:53:46 +01:00
c4f79af56d
Merge branch 'master' into CalcEngine-Refactor-Branch-Pruning
2022-03-04 14:40:34 +01:00
39bba33d00
Merge pull request #2640 from PHPOffice/CSV-Reader-Dataype-casting-improvements
...
Csv reader dataype casting improvements
2022-03-04 14:39:00 +01:00
dd981a3d77
Merge branch 'master' into CSV-Reader-Dataype-casting-improvements
2022-03-04 14:25:37 +01:00
e243476f77
Initial work on refactoring branch pruning logic
2022-03-04 13:55:06 +01:00
23631cb9e5
Correct fill color example in conditional formatting docs. ( #2646 )
2022-03-04 01:41:21 -08:00
dade9cc063
Corrupt Sample Output for 20 and 30 ( #2648 )
...
Xls Reader can read drawing offsetX and offsetY as float. However, Excel Xlsx (and PhpSpreadsheet) wants them only as int. This leads 20_Read_Xls and 30_Template to produce corrupt Xlsx files for any Php release. Change Xls Reader to treat values as int, eliminating the corrupt files.
2022-03-04 00:51:11 -08:00
e87be5e16d
Failing Test Requiring Too Much Precision ( #2647 )
...
The new array tests for IMCSC fail on my system because of a rounding error in the 14th (!) decimal position. This is not a real failure. Change the test to use only the first 8 decimal positions.
2022-03-04 00:11:04 -08:00
aad91f1d25
Merge branch 'master' into CSV-Reader-Dataype-casting-improvements
...
# Conflicts:
# src/PhpSpreadsheet/Reader/Csv.php
2022-03-02 12:43:19 +01:00
45ca934a53
Update Change Log and Documentation
2022-03-02 12:33:20 +01:00
f3d5028518
Work on setting up locale-aware formatted number conversion for the Csv Reader
...
Unit tests for locale-aware boolean conversion for Csv Reader
2022-03-02 08:53:29 +01:00
a7a48bf0ca
Bump dompdf/dompdf from 1.1.1 to 1.2.0 ( #2633 )
...
Bumps [dompdf/dompdf](https://github.com/dompdf/dompdf ) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/dompdf/dompdf/releases )
- [Commits](https://github.com/dompdf/dompdf/compare/v1.1.1...v1.2.0 )
---
updated-dependencies:
- dependency-name: dompdf/dompdf
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-01 03:58:33 -08:00
30815cc060
Bump phpunit/phpunit from 9.5.13 to 9.5.16 ( #2635 )
...
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit ) from 9.5.13 to 9.5.16.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases )
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-9.5.md )
- [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.5.13...9.5.16 )
---
updated-dependencies:
- dependency-name: phpunit/phpunit
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-01 03:48:06 -08:00
a8ebf45fd7
Bump phpstan/phpstan from 1.4.5 to 1.4.6 ( #2634 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 1.4.5 to 1.4.6.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Changelog](https://github.com/phpstan/phpstan/blob/master/CHANGELOG.md )
- [Commits](https://github.com/phpstan/phpstan/compare/1.4.5...1.4.6 )
---
updated-dependencies:
- dependency-name: phpstan/phpstan
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-01 03:34:55 -08:00
f575d2b8b2
Add Ability to Suppress Mac Line Ending Check for CSV Reader ( #2623 )
...
With the deprecation of `auto_detect_line_endings` in Php8.1, there have been some tickets (issue #2609 and PR #2438 ). Although the deprecation message is suppressed, users with a homegrown error handler may still see it. I am not very concerned about that symptom, but I imagine that there will be more similar tickets in future. This PR adds a new property/method to Reader/CSV to allow the user to avoid the deprecated code, at the negligible cost of being unable to read a CSV with Mac line endings even on a Php version that could support it.
2022-03-01 02:01:37 -08:00
8258919d72
Phpstan Differences from Php7 to Php8 ( #2631 )
...
These changes were already implemented as PR #2428 . They were, alas, regressed by PR #2585 . If at first you don't succeed ...
As configured, Phpstan running under Php7 reports no errors. However, running under Php8, it reports 100 (!) errors. The vast majority of these are due to two reasons:
- renaming parameters in Php builtin functions in preparation for named parameters.
- using the new class GdImage rather than type resource as the argument type for many image-based functions.
Regardless of the cause, this will be a problem sooner or later. This PR is an attempt to get ahead of that problem. For source members, it tweaks only the Phpstan configuration files, without changing any PhpSpreadsheet code. For the small number of test members involved, the code is fixed. Php7 and Php8 both report no errors with this configuration.
Because this involves no changes to code, and because Phpstan baseline is a common cause of merge difficulties, I will probably merge this in a day or two, more quickly than I customarily do.
2022-03-01 01:53:12 -08:00
5579712688
Make CSV Reader boolean casting (e.g. string `"TRUE" to boolean TRUE) locale-aware.
2022-02-27 23:06:22 +01:00
f64e2c2408
Prep-work for handling matrix arithmetic in the calc engine, with some basic unit tests
2022-02-27 22:19:12 +01:00
55be3b4b5a
Minor typehint fixes
2022-02-27 22:05:44 +01:00
cff8303f1b
Re-merge from baseline
2022-02-27 14:15:49 +01:00
4d0f426f4f
Merge branch 'master' into CalculationEngine-Array-Formulae-Initial-Work
2022-02-27 13:51:46 +01:00
fe969f59cc
Merge pull request #2627 from PHPOffice/Improve-Translation-Separator-Conflict
...
Resolve `translateSeparator()` method to handle separators cleanly
Some refactoring of the Ods Reader classes to eliminate code duplication
2022-02-27 13:48:45 +01:00
b31d42c52f
Some Refactoring of the Ods Reader, moving all formula and address translation from Ods to Excel into a separate class to eliminate code duplication
2022-02-27 13:31:24 +01:00
99f488efc6
Resolve translateSeparator() method to handle separators (row and column) for array functions as well as for function argument separators; and cleanly handle nesting levels
...
Note that this method is used when translating Excel functions between en and other locale languages, as well as when converting formulae between different spreadsheet formats (e.g. Ods to Excel)
Nor is this a perfect solution, as there may still be issues when function calls have array arguments that themselves contain function calls; but it's still better than the current logic
2022-02-27 13:01:09 +01:00
e1f278bb20
Unit tests for reading/writing array formulae from Ods
2022-02-27 12:45:48 +01:00
MarkBaker
Paul Weidner
oleibman
dependabot[bot]