Commit Graph

1718 Commits

Author SHA1 Message Date
Adrien Crivelli d9bd45f4f1 Fix unit tests 2017-12-23 14:59:23 +09:00
Adrien Crivelli 80e46707aa Fix code style 2017-12-23 14:40:51 +09:00
Alessandro Lai 453f8f1821 Simplify substr usages 2017-12-23 14:37:04 +09:00
Alessandro Lai 30ec11c7fa Optimize regex using \d 2017-12-23 14:36:08 +09:00
Alessandro Lai cfc325ab57 Fix PHPDoc to avoid erroneous warning in IDE 2017-12-23 14:35:13 +09:00
Alessandro Lai 5bdb3ba210 Simplify return statement 2017-12-23 14:34:49 +09:00
Alessandro Lai b77352f153 Add regex delimiter for proper escaping 2017-12-23 14:33:50 +09:00
Alessandro Lai b5057f44b1 Avoid race condition 2017-12-23 14:32:27 +09:00
Alessandro Lai a653e09bf0 Remove duplicated code and call parent methods where possible 2017-12-23 14:28:28 +09:00
Alessandro Lai f246ad731d Remove redundant function calls in for loops 2017-12-23 14:22:21 +09:00
Adrien Crivelli d383bc356c Restore reference to calculation engine 2017-12-20 00:20:38 +09:00
Adrien Crivelli cfcafd3e73 Typo in docs 2017-12-20 00:20:38 +09:00
Terje Bråten 8288a7f029 Documentation change for column indexing 2017-12-19 12:07:19 +09:00
Adrien Crivelli 67767e1402 Incorrect class in documentation 2017-12-17 23:11:25 +09:00
Adrien Crivelli e4b98d268d Prevent checkboxes to be interpreted as todo list 2017-12-17 19:17:19 +09:00
Adrien Crivelli 341e82f6eb Line ending is detected automatically since commit f2310e05d
Closes #293
2017-12-17 16:49:37 +09:00
Adrien Crivelli 32a55a3f13 Introduce identical functional tests across several formats 2017-12-17 16:35:20 +09:00
Adrien Cohen 11b055b29f Able to set the topLeftCell in freeze panes
Fixes #260
Closes #261
2017-12-17 13:32:16 +09:00
Adrien Crivelli eb58563b4b Written DataValidation was corrupted
Fixes #290
2017-12-16 17:15:13 +09:00
Adrien Crivelli 04a8ddffa2 Accept no change of coverage 2017-12-16 15:54:24 +09:00
Adrien Crivelli a204e0c7ec Constant TYPE_DOUGHTNUTCHART is now TYPE_DOUGHNUTCHART 2017-12-13 19:54:25 +09:00
Adrien Crivelli 08e860b993 Uncomment test cases 2017-12-11 12:22:49 +09:00
Adrien Crivelli 96f3f666d6 Support to write merged cells in ODS format
Fixes #287
2017-12-11 12:17:40 +09:00
Adrien Crivelli 962367c95f Can read very small HTML files
Fixes #194
2017-12-11 11:09:25 +09:00
Gabriel Caruso dfcab0c13f Use assertInstanceOf (#286) 2017-12-06 18:46:31 +09:00
Adrien Crivelli 8041a87f7a Configure stale and support Probots 2017-12-04 19:05:09 +09:00
Adrien Crivelli 3c9208cff9 Don't run phpcs because it is also run on Travis anyway 2017-12-04 16:49:32 +09:00
Adrien Crivelli 812a468844 New method evaluateGCD() should stay private 2017-12-03 17:20:45 +09:00
Adrien Crivelli 3068fcfb12 Enable Scrutinizer build failure if coverage decrease 2017-12-03 17:17:33 +09:00
MarkBaker 90366f9dd1 style fixes 2017-11-26 23:18:11 +00:00
MarkBaker 19fd27811d Improved GCD() evaluation and additional tests 2017-11-26 22:13:29 +00:00
Adrien Crivelli 59326f1064 1.0.0-beta2 1.0.0-beta2 2017-11-26 15:47:24 +09:00
Adrien Crivelli 8d76020590 Consistent stringFromColumnIndex() and columnIndexFromString()
Column indexes are always based on 1 everywhere in PhpSpreadsheet.
This is consistent with rows starting at 1, as well as Excel
function `COLUMN()`. It should also make it easier to reason about
columns and rows and remove any doubts whether a specific method is
expecting 0 based or 1 based indexes.

Fixes #273
Fixes https://github.com/PHPOffice/PHPExcel/issues/307
Fixes https://github.com/PHPOffice/PHPExcel/issues/476
2017-11-26 15:29:08 +09:00
Adrien Crivelli e0150fd43e Extract coordinate methods to Coordinate class 2017-11-18 23:52:38 +09:00
Adrien Crivelli 1cec980167 Mention SO and Gitter for support 2017-11-12 21:03:02 +09:00
Gabriel Caruso aed27a0bed Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase (#271)
Use the `PHPUnit\Framework\TestCase` notation instead of `PHPUnit_Framework_TestCase` while extending our TestCases. This will help us migrate to PHPUnit 6, that [no longer support snake case class names](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md#changed-1).
2017-11-09 00:48:01 +09:00
Maxim Bulygin 442e612202 Support custom PDF library instances or configurations
This allow to create and configure the standard instance of the
external PDF libary, before returning it to the standard writer.

Or, more powerful, this allow to provide a custom implementation
of the external PDF library, allowing for custom behaviors. An
example of that would something like: https://tcpdf.org/examples/example_003/

Closes #266
2017-11-04 16:01:09 +09:00
Adrien Crivelli 40efcd2fdd Rename tests according to the class the class they are testing 2017-11-03 12:47:19 +09:00
Adrien Crivelli 98b532102d Add experimental support for PHP 7.2 2017-11-02 16:02:42 +09:00
Adrien Crivelli b2ab08b1b5 Mention composer fix in contributing guide 2017-11-02 15:50:01 +09:00
anton-harvey f7518dadc9 Return false if the zip entry could not be located
Previously the function did not check whether the return value of `ZipArchive::locateName`
was `false`. And when it was, it was passed straight into `ZipArchive::getFromIndex`,
which casts it to an integer, resulting in it incorrectly retrieving the entry at index `0`.

Fixes #262
Closes #268
2017-11-02 15:42:45 +09:00
Adrien Crivelli 8183c71e78 Remove duplicated declarations of interface implementation 2017-10-31 19:58:46 +09:00
Maxim Bulygin 6561494e32 Add possibility to check validity of a cell value, based on data validation rules
`$cell->hasValidValue()` returns true if the cell has a value which conform to the
rules defined in `$cell->getDataValidation()`.

Closes #257
2017-10-31 14:07:24 +09:00
Adrien Crivelli 888c618227 Fix typo 2017-10-30 11:37:24 +09:00
Adrien Crivelli 8d23bda3dd Fix Scrutinizer issues 2017-10-29 23:34:00 +09:00
Adrien Crivelli 557e80dc03 Rename classes to keep them in their related namespaces 2017-10-29 17:39:42 +09:00
Adrien Crivelli 3982ce2944 Remove unused variables and parameters 2017-10-29 14:09:38 +09:00
Adrien Crivelli 782b4e4fae Upgrade chart rendering support to be composer based
This allow to get rid of manual class loading and have simpler
usage of the library.
2017-10-29 01:58:42 +09:00
Adrien Crivelli dc9f4327b6 Declare all dependencies with the help of composer-require-checker 2017-10-28 23:22:50 +09:00
Adrien Crivelli b4a187bef8 Fix missing classes 2017-10-28 22:52:23 +09:00