mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-08-30 12:07:56 +00:00
oleibman
070bc68514
Fix #2810. Repairing some Phpstan diagnostics, used `?:` rather than `??` in a few places. 2 different Html modules are affected. Also, Ods Reader, but its problem is with sheet title rather than cell contents. And, as it turns out, Ods Reader was already not handling sheets with a title of `0` correctly - it made a truthy test before setting sheet title. That is now changed to truthy or numeric. Other readers are not susceptible to this problem. Tests are added.
41 lines
915 B
PHP
41 lines
915 B
PHP
<?php
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Reader\Html;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Reader\Html;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class Issue2810Test extends TestCase
|
|
{
|
|
// Reader has been converting falsey values to null
|
|
public function testIssue2810(): void
|
|
{
|
|
$content = <<<'EOF'
|
|
<!DOCTYPE html>
|
|
<html>
|
|
<head>
|
|
<meta charset='utf-8'>
|
|
<title>Declaracion en Linea</title>
|
|
</head>
|
|
<body>
|
|
<table>
|
|
<tr>
|
|
<td>1</td>
|
|
<td>0</td>
|
|
<td>2</td>
|
|
</tr>
|
|
</table>
|
|
</body>
|
|
</html>
|
|
|
|
EOF;
|
|
$reader = new Html();
|
|
$spreadsheet = $reader->loadFromString($content);
|
|
$sheet = $spreadsheet->getActiveSheet();
|
|
self::assertSame(1, $sheet->getCell('A1')->getValue());
|
|
self::assertSame(0, $sheet->getCell('B1')->getValue());
|
|
self::assertSame(2, $sheet->getCell('C1')->getValue());
|
|
$spreadsheet->disconnectWorksheets();
|
|
}
|
|
}
|