mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-03 05:57:46 +00:00
oleibman
057572ee90
* Change Additional Statistical Tests to Use Spreadsheet Context With an earlier change, I made all but 18 Statistical tests run in spreadsheet context. This PR changes 12 of those 18. The remaining 6 usually return array results, so it is a tougher task to handle them. I will continue to think on it. AVERAGEIF, AVERAGEIFS, and COUNTBLANK are changed to throw an Exception when a range is specified as a literal. They previously accepted array (enclosed in braces) literals, and bumbled along till they threw an error for non-array literals. Throwing an exception appears to be analogous to how Excel operates, rather than something more friendly like a VALUE error. There may be other functions which require similar treatment. There also remains a TODO for COUNTIFS, and possibly other functions. It appears that PhpSpreadsheet counts booleans for both integer and string compares and probably shouldn't. Again, this is a problem for another day. * Scrutinizer Fix one problem. * Scrutinizer Ignores Its Own Suggested Remedy Try another approach.
48 lines
1.6 KiB
PHP
48 lines
1.6 KiB
PHP
<?php
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\Statistical;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Calculation\Exception as CalcException;
|
|
|
|
class AverageIfTest extends AllSetupTeardown
|
|
{
|
|
/**
|
|
* @dataProvider providerAVERAGEIF
|
|
*
|
|
* @param mixed $expectedResult
|
|
*/
|
|
public function testAVERAGEIF($expectedResult, ...$args): void
|
|
{
|
|
$this->runTestCaseNoBracket('AVERAGEIF', $expectedResult, ...$args);
|
|
}
|
|
|
|
public function providerAVERAGEIF(): array
|
|
{
|
|
return require 'tests/data/Calculation/Statistical/AVERAGEIF.php';
|
|
}
|
|
|
|
public function testOutliers(): void
|
|
{
|
|
$sheet = $this->getSheet();
|
|
$sheet->getCell('C1')->setValue(5);
|
|
$sheet->getCell('A1')->setValue('=AVERAGEIF(5,"<32")');
|
|
|
|
try {
|
|
$sheet->getCell('A1')->getCalculatedValue();
|
|
self::fail('Should receive exception for non-array arg');
|
|
} catch (CalcException $e) {
|
|
self::assertStringContainsString('Must specify range of cells', $e->getMessage());
|
|
}
|
|
$sheet->getCell('A2')->setValue('=AVERAGEIF({5},"<32")');
|
|
|
|
try {
|
|
$sheet->getCell('A2')->getCalculatedValue();
|
|
self::fail('Should receive exception for literal array arg');
|
|
} catch (CalcException $e) {
|
|
self::assertStringContainsString('Must specify range of cells', $e->getMessage());
|
|
}
|
|
$sheet->getCell('A3')->setValue('=AVERAGEIF(C1,"<32")');
|
|
self::assertSame(5, $sheet->getCell('A3')->getCalculatedValue(), 'first arg is single cell');
|
|
}
|
|
}
|