mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-16 13:06:31 +00:00
oleibman
1cdc6cd2fb
* Breaking Change to toFormattedString and 3 toArray Methods DocBlock says `toFormattedString` returns string, but code can return int, float, bool, null, or RichText. I think the DocBlock is correct (function name clearly indicates "to string"), and the code needs to change to match it. This is not that big a deal on its own. However, some methods in `Worksheet` call this function by default - `rangeToArray`, `toArray`, and `namedRangeToArray`. All 3 can be called with a parameter so that they don't call `toFormattedString`, but, by default, they do call, and so are affected by this change. Some unit test results are changed as a result of this code change. In all those cases, an additional test is added which would match the previous result. * Update Change Log I often skip this till later, but, since it's a breaking change ... * Scrutinizer, Plus Strange Cast to -0 Avoid Scrutinizer complaint by casting string to float, but ... Php decides resulted should sometimes be `-0`? That caused test failures. Very odd.
48 lines
1.4 KiB
PHP
48 lines
1.4 KiB
PHP
<?php
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Reader\Xlsx;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Reader\Xlsx;
|
|
use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class HiddenWorksheetTest extends TestCase
|
|
{
|
|
public function testPageSetup(): void
|
|
{
|
|
$filename = 'tests/data/Reader/XLSX/HiddenSheet.xlsx';
|
|
$reader = new Xlsx();
|
|
$spreadsheet = $reader->load($filename);
|
|
$assertions = $this->worksheetAssertions();
|
|
|
|
foreach ($spreadsheet->getAllSheets() as $worksheet) {
|
|
if (!array_key_exists($worksheet->getTitle(), $assertions)) {
|
|
continue;
|
|
}
|
|
|
|
$sheetAssertions = $assertions[$worksheet->getTitle()];
|
|
foreach ($sheetAssertions as $test => $expectedResult) {
|
|
$actualResult = $worksheet->getSheetState();
|
|
self::assertSame(
|
|
$expectedResult,
|
|
$actualResult,
|
|
"Failed asserting sheet state {$expectedResult} for Worksheet '{$worksheet->getTitle()}' {$test}"
|
|
);
|
|
}
|
|
}
|
|
$spreadsheet->disconnectWorksheets();
|
|
}
|
|
|
|
private function worksheetAssertions(): array
|
|
{
|
|
return [
|
|
'Sheet1' => [
|
|
'sheetState' => Worksheet::SHEETSTATE_VISIBLE,
|
|
],
|
|
'Sheet2' => [
|
|
'sheetState' => Worksheet::SHEETSTATE_HIDDEN,
|
|
],
|
|
];
|
|
}
|
|
}
|