mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-24 09:09:22 +00:00
oleibman
ef81f19996
Fix #3899. Supersedes PR #4476, which will be changed to draft status and closed if this PR is merged. A standard cast from float to string in PHP can drop trailing decimal positions. This can lead to problems above and beyond the usual problems associated with floating point. See the superseded PR for a more complete explanation. `StringHelper::convertToString` is changed for how it handles floats. It will now do separate casts for the whole and decimal parts, and then combine the results. This affects `Cell::getValueString` and `Cell::getCalculatedValueString`. Xlsx Writer will now invoke `convertToString` before writing a float to Xml. Ods Writer already uses `getValueString`, so no change is needed there. Xls Writer writes its float values in binary, so no change is needed there. Tests are added for all 3 writers. Aside from fixing some problems, it might appear that this change introduces some new problems. For instance, setting a cell to `12345.6789` will now result in `12345.67890000000079` in the Xml. This difference is an illusion, merely a consequence of floating point rounding. If you run the following check under PhpUnit, it will pass: ```php self::assertSame(12345.6789, 12345.67890000000079); ```
78 lines
3.2 KiB
PHP
78 lines
3.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\MathTrig;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
|
|
|
|
class TruncTest extends AllSetupTeardown
|
|
{
|
|
#[\PHPUnit\Framework\Attributes\DataProvider('providerTRUNC')]
|
|
public function testTRUNC(mixed $expectedResult, string $formula): void
|
|
{
|
|
$this->mightHaveException($expectedResult);
|
|
$sheet = $this->getSheet();
|
|
$sheet->setCellValue('A2', 1.3);
|
|
$sheet->setCellValue('A3', 2.7);
|
|
$sheet->setCellValue('A4', -3.8);
|
|
$sheet->setCellValue('A5', -5.2);
|
|
$sheet->getCell('A1')->setValue("=TRUNC($formula)");
|
|
$result = $sheet->getCell('A1')->getCalculatedValue();
|
|
self::assertEqualsWithDelta($expectedResult, $result, 1E-12);
|
|
}
|
|
|
|
public static function providerTRUNC(): array
|
|
{
|
|
return require 'tests/data/Calculation/MathTrig/TRUNC.php';
|
|
}
|
|
|
|
#[\PHPUnit\Framework\Attributes\DataProvider('providerTruncArray')]
|
|
public function testTruncArray(array $expectedResult, string $argument1, string $argument2): void
|
|
{
|
|
$calculation = Calculation::getInstance();
|
|
|
|
$formula = "=TRUNC({$argument1}, {$argument2})";
|
|
$result = $calculation->_calculateFormulaValue($formula);
|
|
self::assertEqualsWithDelta($expectedResult, $result, 1.0e-14);
|
|
}
|
|
|
|
public static function providerTruncArray(): array
|
|
{
|
|
return [
|
|
'matrix' => [[[3.14, 3.141], [3.14159, 3.14159265]], '3.1415926536', '{2, 3; 5, 8}'],
|
|
];
|
|
}
|
|
|
|
#[\PHPUnit\Framework\Attributes\DataProvider('providerTooMuchPrecision')]
|
|
public function testTooMuchPrecision(mixed $expectedResult, float|int|string $value, int $digits = 1): void
|
|
{
|
|
// This test is pretty screwy. Possibly shouldn't even attempt it.
|
|
// At any rate, these results seem to indicate that PHP
|
|
// maximum precision is PHP_FLOAT_DIG - 1 digits, not PHP_FLOAT_DIG.
|
|
// If that changes, at least one of these tests will have to change.
|
|
$sheet = $this->getSheet();
|
|
$sheet->getCell('E1')->setValue($value);
|
|
$sheet->getCell('E2')->setValue("=TRUNC(E1,$digits)");
|
|
/** @var float|string */
|
|
$result = $sheet->getCell('E2')->getCalculatedValue();
|
|
self::assertSame($expectedResult, (string) $result);
|
|
}
|
|
|
|
public static function providerTooMuchPrecision(): array
|
|
{
|
|
$max64Plus1 = 9223372036854775808;
|
|
$stringMax = (string) $max64Plus1;
|
|
|
|
return [
|
|
'2 digits less than PHP_FLOAT_DIG' => ['1' . str_repeat('0', PHP_FLOAT_DIG - 4) . '1.2', 10.0 ** (PHP_FLOAT_DIG - 3) + 1.2, 1],
|
|
'1 digit less than PHP_FLOAT_DIG' => ['1' . str_repeat('0', PHP_FLOAT_DIG - 3) . '1', 10.0 ** (PHP_FLOAT_DIG - 2) + 1.2, 1],
|
|
'PHP_FLOAT_DIG' => ['1.0E+' . (PHP_FLOAT_DIG - 1), 10.0 ** (PHP_FLOAT_DIG - 1) + 1.2, 1],
|
|
'1 digit more than PHP_FLOAT_DIG' => ['1.0E+' . PHP_FLOAT_DIG, 10.0 ** PHP_FLOAT_DIG + 1.2, 1],
|
|
'32bit exceed int max' => ['3123456780', 3123456789, -1],
|
|
'64bit exceed int max neg decimals' => [$stringMax, $max64Plus1, -1],
|
|
'64bit exceed int max pos decimals' => [$stringMax, $max64Plus1, 1],
|
|
];
|
|
}
|
|
}
|