geckon01/Twig
1
0
Fork 0
mirror of https://github.com/twigphp/Twig.git synced 2026-09-17 21:07:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor #3936 Remove usage of isset before array_key_exists as performance is not an issue anymore (fabpot)

Browse Source 
This PR was merged into the 4.x branch.

Discussion
----------

Remove usage of isset before array_key_exists as performance is not an issue anymore

Commits
-------

c8d6df7e Remove usage of isset before array_key_exists as performance is not an issue anymore
This commit is contained in:
Fabien Potencier
2023-12-09 17:25:54 +01:00
parent a2eb71ce66 c8d6df7eb2
commit 7e48b0aa83
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Node/Expression/NameExpression.php
+1 -3
View File
@@ -60,9 +60,7 @@ class NameExpression extends AbstractExpression
;
} else {
$compiler
->raw('(isset($context[')
->string($name)
->raw(']) || array_key_exists(')
->raw('(array_key_exists(')
->string($name)
->raw(', $context) ? $context[')
->string($name)
tests/Node/Expression/NameTest.php
+1 -1
View File
@@ -34,7 +34,7 @@ class NameTest extends NodeTestCase
$env = new Environment($this->createMock(LoaderInterface::class), ['strict_variables' => true]);
$env1 = new Environment($this->createMock(LoaderInterface::class), ['strict_variables' => false]);
$output = '(isset($context["foo"]) || array_key_exists("foo", $context) ? $context["foo"] : throw new RuntimeError(\'Variable "foo" does not exist.\', 1, $this->source))';
$output = '(array_key_exists("foo", $context) ? $context["foo"] : throw new RuntimeError(\'Variable "foo" does not exist.\', 1, $this->source))';
return [
[$node, "// line 1\n".$output, $env],