feature #3763 Remove internal from ExpressionParser (VincentLanglet)

mirror of https://github.com/twigphp/Twig.git synced 2026-09-11 09:56:32 +00:00

This PR was merged into the 3.x branch.

Discussion
----------

Remove internal from ExpressionParser

In the advanced doc, it's explained how to write TokenParser:
https://github.com/twigphp/Twig/blob/3.x/doc/advanced.rst#defining-a-token-parser

Such an implementation rely on method like
ExpressionParser::parseExpression or Expression::parseMultitargetExpression,

Currently the ExpressionParser is marked as internal, implying all the method are also internal.
It would be great to promise BC about those methods since they are require/usefull for custom TokenParser.

I dunno if the ``@internal`` tag is still needed for some methods of the ExpressionParser (like the constructor ?).

This would also
Closes https://github.com/twigphp/Twig/issues/3443

Commits
-------

de0f947e Remove internal from ExpressionParser

This commit is contained in:

Fabien Potencier

2022-10-22 14:59:12 +02:00

parent 6ddd95c709 de0f947efc

commit ce55cb842e

1 changed files with 0 additions and 2 deletions

									
										src/ExpressionParser.php
									
		-2
	
												View File
												
				@@ -40,8 +40,6 @@ use Twig\Node\Node;

				 * @see https://en.wikipedia.org/wiki/Operator-precedence_parser

				 *

				 * @author Fabien Potencier <fabien@symfony.com>

				 *

				 * @internal

				 */

				class ExpressionParser

				{