This PR was merged into the 3.x branch.
Discussion
----------
Fix wrong type for cycle position
It also accepts 0, which is not a positive int.
Commits
-------
c78499bda9 Fix wrong type for cycle position
This PR was merged into the 3.x branch.
Discussion
----------
Add type for join method
Looking at the code, this method is very forgiving in what it accepts.
This helps PHPStan to not complain when something other than an array is passed.
Did I miss other types?
/cc `@stof`
Commits
-------
226f0ff0dd Add type for join method
This PR was merged into the 3.x branch.
Discussion
----------
Rely on reflection to access null properties
Benchmark like https://gist.github.com/arnaud-lb/c4235164fb41e11672aa670da8fa4fc7 (which were done for another use case but is still relevant here) prove that using reflection instead of array-casts is significantly faster for accessing properties.
Checking for dynamic properties is done with property_exists.
Commits
-------
5cd1ff1977 Rely on reflection to access null properties
* 3.14.x:
Improve detection of recursion
Fix recursion when arrays contain self-references in sandboxed mode
Fix code
Prepare the 3.11.2 release
Update CHANGELOG
Sandbox ArrayAccess and do sandbox checks before isset() checks
Fix sandbox handling for __toString()
Prepare the 3.14.1 release
Update CHANGELOG
Sandbox ArrayAccess and do sandbox checks before isset() checks
Fix sandbox handling for __toString()
Prepare the 3.11.1 release
Fix a security issue when an included sandboxed template has been loaded before without the sandbox context
* 3.11.x:
Improve detection of recursion
Fix recursion when arrays contain self-references in sandboxed mode
Fix code
Prepare the 3.11.2 release
Update CHANGELOG
Sandbox ArrayAccess and do sandbox checks before isset() checks
Fix sandbox handling for __toString()
Prepare the 3.11.1 release
Fix a security issue when an included sandboxed template has been loaded before without the sandbox context
This PR was squashed before being merged into the 3.x branch.
Discussion
----------
Fix mistake in docs for `keys` filter
Commits
-------
deb37c30c4 Fix mistake in docs for `keys` filter
This PR was squashed before being merged into the 3.x branch.
Discussion
----------
[String] Add SpanishInflector support for singular and plural
This PR implement a new Inflector using Spanish (ISO Code = es) implemented in this PR symfony/symfony#58228.
* I sort the list of supported Inflectors to follow some rule (alphabet?)
* I just change invalid test from "it" to "qq" (qq doesn't exist as valid ISO code, but it is italian... don't be evil if anyone want to create the italian inflector 😅 )
Commits
-------
290a923a42 [String] Add SpanishInflector support for singular and plural
This PR was merged into the 3.x branch.
Discussion
----------
Remove duplicate test case
The test cases in line `7` and `9` were the same.
Commits
-------
d59cc8baa5 Remove duplicate test case
This PR was merged into the 3.x branch.
Discussion
----------
Add `$this` return type to Template::unwrap
See https://phpstan.org/writing-php-code/phpdoc-types#static-and-%24this
This way, PHPStan understands that the returned template is the exact same instance, and not just a Template.
Commits
-------
92e4989002 Add `$this` return type to Template::unwrap
This PR was squashed before being merged into the 3.x branch.
Discussion
----------
Add link to TwigQI in docs "You might also be interested in" section
As proposed by Fabien last Thursday at Evolve. Merci beaucoup!
Commits
-------
4a0568521a Add link to TwigQI in docs "You might also be interested in" section
This PR was merged into the 3.x branch.
Discussion
----------
Add return type to compiled macro
This makes it easier for TwigStan to analyze the return type.
Commits
-------
1e7c719e24 Add return type to compiled macro
This PR was merged into the 3.x branch.
Discussion
----------
do not drop none digit characters from generated variable names
I was wondering if it was really intended to cast the var name generated by the compiler to an int as done in #4398. Doesn't this create the risk of variable names being reused at some point?
Commits
-------
5b0209ffa3 do not drop none digit characters from generated variable names
Jacob Dreesen
Fabien Potencier
Nicolas Grekas
Lee Rowlands
Ruud Kamphuis
Dennis Tobar
Jeroen Versteeg
Christian Flothmann