Commits
-------
c53a02d Fixed DateTimeZone support in date filter.
Discussion
----------
Fixed DateTimeZone support in date filter.
Now $date converted to a DateTime has a DateTimeZone in every case.
---------------------------------------------------------------------------
by fabpot at 2012-05-28T19:20:47Z
Can you add some unit tests to avoid regression to happen later? Thanks.
---------------------------------------------------------------------------
by blaugueux at 2012-05-29T07:52:58Z
@fabpot Here they are.
---------------------------------------------------------------------------
by fabpot at 2012-05-29T10:29:28Z
Great! Can you add a note in the CHANGELOG file and then squash your commit before I merge? Thanks.
---------------------------------------------------------------------------
by blaugueux at 2012-05-29T12:52:22Z
Changelog added. First squash of my life, i cannot say if it's good :(
---------------------------------------------------------------------------
by stof at 2012-05-29T12:55:26Z
it is not. you merged your remote branch instead of forcing the push
---------------------------------------------------------------------------
by blaugueux at 2012-05-29T17:12:05Z
Ok @stof, thanks for your help. I think it's good now.
@fabpot Is it ok for you ?
Commits
-------
f0a0036 Add abs filter including unit test and documentation
Discussion
----------
Add abs filter to Twig
With abs it is possible to make negative values positive and leave positive values positive.
---------------------------------------------------------------------------
by maartendekeizer at 2012-05-26T19:02:34Z
Example when using abs
{% if days_left < 0 %}
{{ days_left|abs }} days to late!
{% else %}
{{ days_left }} days left
{% endif %}
---------------------------------------------------------------------------
by stof at 2012-05-26T19:12:43Z
I'm not sure about adding this filter in the core. I think it would be better in the Twig-extensions repo. @fabpot thoughts ?
---------------------------------------------------------------------------
by maartendekeizer at 2012-05-26T21:18:47Z
@stof abs is a really basic/natural function it belongs to the base mathematic functions. If this was an implementation of for example the ABC-formula or Pythagoras it must be in the extension repo., but abs is more core related I think.
---------------------------------------------------------------------------
by fabpot at 2012-05-27T07:11:33Z
Can you add some unit tests and squash your commits? Thanks.
---------------------------------------------------------------------------
by maartendekeizer at 2012-05-27T14:40:56Z
First time squashing commits; learned something new :-). I will add a unit test tomorrow.
---------------------------------------------------------------------------
by maartendekeizer at 2012-05-27T17:36:58Z
Unit test and documentation added.
---------------------------------------------------------------------------
by fabpot at 2012-05-27T18:41:25Z
After fixing the markup issue, you will have to squash again ;)
---------------------------------------------------------------------------
by maartendekeizer at 2012-05-27T20:44:29Z
Done
---------------------------------------------------------------------------
by fabpot at 2012-05-28T19:19:55Z
Looks like you have not squash your commits.
---------------------------------------------------------------------------
by maartendekeizer at 2012-05-28T20:05:34Z
@fabot you want one commit for the complete pr?
---------------------------------------------------------------------------
by fabpot at 2012-05-28T20:06:53Z
For such a PR, yes.
Commits
-------
953a0ce [doc] fixed Composer section of the introduction. Added a side note to the Composer official documentation for getting more information.
Discussion
----------
[doc] fixed twig version in installation documentation.
---------------------------------------------------------------------------
by lyrixx at 2012-05-25T23:30:01Z
why not use something like "1.*" ?
---------------------------------------------------------------------------
by fabpot at 2012-05-26T05:55:16Z
This is just an example and we are not going to update it with each new release. So, we can either use `1.*` as suggested by @lyrixx or/and add a note referring to the Composer docs.
---------------------------------------------------------------------------
by hhamon at 2012-05-28T05:34:54Z
That's better indeed!
---------------------------------------------------------------------------
by hhamon at 2012-05-28T05:40:46Z
@fabpot you can merge this PR
---------------------------------------------------------------------------
by fabpot at 2012-05-28T06:07:05Z
Can you squash?
---------------------------------------------------------------------------
by hhamon at 2012-05-28T06:31:42Z
@fabpot squashed!
Commits
-------
b692268 removed leftover of 93c4406f8 and made some language improvements
Discussion
----------
removed leftover of 93c4406f8 and made some language improvements
Commits
-------
d13f742 fix example in doc for embed tag
b11412e improve documentation for embed tag
Discussion
----------
improve documentation for embed tag
https://github.com/fabpot/Twig/issues/722
---------------------------------------------------------------------------
by fabpot at 2012-05-10T05:10:37Z
I think this is a great improvement over the original version! The notion of "micro-layouts" certainly helps understand the concept behind the `embed` tag.
Thanks.
This avoids some hard to find bugs where you use a Twig_Function_Method
for instance for a filter. This is hard to find because the interface is
almost the same but the getSafe() contract is not the same.
Commits
-------
a23d4fb Fixed the handling of the timezone for DateTime objects
a164469 Added a failing test demonstrating the bug with DateTime and timezones
Discussion
----------
Mutable datetime
PHP DateTime objects are mutable so changing the timezone when displaying
it affects the following code whereas it does not occur for other
supported formats.
PHP DateTime objects are mutable so changing the timezone when displaying
it affects the following code whereas it does not occur for other
supported formats.
Chris Sedlmayr
Fabien Potencier
Benjamin Laugueux
Maarten de Keizer
Hugo Hamon
Tobias Schultze
Steven Hoffman
literal
Christophe Coevoet